-
Notifications
You must be signed in to change notification settings - Fork 105
Update procedure for TLS for secure LDAP connection #4257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aneta-petrova
merged 4 commits into
theforeman:master
from
aneta-petrova:32048_tls_for_secure_ldap
Sep 16, 2025
Merged
Update procedure for TLS for secure LDAP connection #4257
aneta-petrova
merged 4 commits into
theforeman:master
from
aneta-petrova:32048_tls_for_secure_ldap
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR preview for 4f1692a is available at theforeman-foreman-documentation-preview-pr-4257.surge.sh The following output files are affected by this PR: |
maximiliankolb
requested changes
Sep 15, 2025
guides/common/modules/proc_configuring-tls-for-secure-ldap.adoc
Outdated
Show resolved
Hide resolved
Tech ack shared in https://issues.redhat.com/browse/SAT-32048 (private comment, sorry, but it's there). |
maximiliankolb
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM
aneta-petrova
added a commit
that referenced
this pull request
Sep 16, 2025
* Highlight important prerequisite * Add step to restart services * Update cert path (cherry picked from commit 09a150a)
aneta-petrova
added a commit
that referenced
this pull request
Sep 16, 2025
* Highlight important prerequisite * Add step to restart services * Update cert path (cherry picked from commit 09a150a)
aneta-petrova
added a commit
that referenced
this pull request
Sep 16, 2025
* Highlight important prerequisite * Add step to restart services * Update cert path (cherry picked from commit 09a150a)
aneta-petrova
added a commit
that referenced
this pull request
Sep 16, 2025
* Highlight important prerequisite * Add step to restart services * Update cert path (cherry picked from commit 09a150a)
aneta-petrova
added a commit
that referenced
this pull request
Sep 16, 2025
* Highlight important prerequisite * Add step to restart services * Update cert path (cherry picked from commit 09a150a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
style review done
No issues from docs style/grammar perspective
tech review done
No issues from the technical perspective
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-32048
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Somewhat related to #3941 which also adds a step to restart services after updating certs.
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):