Skip to content

Conversation

aneta-petrova
Copy link
Member

@aneta-petrova aneta-petrova commented Sep 15, 2025

What changes are you introducing?

  • Highlighting an existing prerequisite as an actual prerequisite so it's harder to miss
  • Adding a step to restart services
  • EDIT: Updating cert location

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-32048

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Somewhat related to #3941 which also adds a step to restart services after updating certs.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

Review checklists

Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):

  • The PR documents a recommended, user-friendly path.
  • The PR removes steps that have been made unnecessary or obsolete.
  • Any steps introduced or updated in the PR have been tested to confirm that they lead to the documented end result.

Style review (by a Technical Writer who did not author the PR):

  • The PR conforms with the team's style guidelines.
  • The PR introduces documentation that describes a user story rather than a product feature.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 15, 2025
@aneta-petrova aneta-petrova removed the Needs testing Requires functional testing label Sep 15, 2025
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Sep 15, 2025
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Sep 16, 2025
@aneta-petrova
Copy link
Member Author

Tech ack shared in https://issues.redhat.com/browse/SAT-32048 (private comment, sorry, but it's there).

@aneta-petrova aneta-petrova added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Sep 16, 2025
@ekohl
Copy link
Member

ekohl commented Sep 16, 2025

I can confirm @waldirio acked in a private comment.

@waldirio next time feel free to review the PR in GitHub. Anyone (even those without commit access) can leave a review and it makes the process more transparent.

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM

@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Sep 16, 2025
@aneta-petrova aneta-petrova merged commit 09a150a into theforeman:master Sep 16, 2025
9 of 10 checks passed
aneta-petrova added a commit that referenced this pull request Sep 16, 2025
* Highlight important prerequisite
* Add step to restart services
* Update cert path

(cherry picked from commit 09a150a)
aneta-petrova added a commit that referenced this pull request Sep 16, 2025
* Highlight important prerequisite
* Add step to restart services
* Update cert path

(cherry picked from commit 09a150a)
aneta-petrova added a commit that referenced this pull request Sep 16, 2025
* Highlight important prerequisite
* Add step to restart services
* Update cert path

(cherry picked from commit 09a150a)
aneta-petrova added a commit that referenced this pull request Sep 16, 2025
* Highlight important prerequisite
* Add step to restart services
* Update cert path

(cherry picked from commit 09a150a)
aneta-petrova added a commit that referenced this pull request Sep 16, 2025
* Highlight important prerequisite
* Add step to restart services
* Update cert path

(cherry picked from commit 09a150a)
@aneta-petrova aneta-petrova deleted the 32048_tls_for_secure_ldap branch September 16, 2025 11:58
@aneta-petrova
Copy link
Member Author

Merged to "master" and cherry-picked:

7b5b31e..90caa45 3.16 -> 3.16
65eb2af..f9fccf7 3.15 -> 3.15
8f93983..dbf7c6a 3.14 -> 3.14
31901b7..94e445c 3.13 -> 3.13
6694e2c..d65f1d0 3.12 -> 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants