Republish metadata via Hammer CLI - #4307
Conversation
github-actions
Bot
added
Needs tech review
|
The PR preview for f77a557 is available at theforeman-foreman-documentation-preview-pr-4307.surge.sh The following output files are affected by this PR: |
Lennonka
left a comment
Lennonka
left a comment
There was a problem hiding this comment.
I've requested testing of the commands. We should get an ack here.
pr-processor
Bot
added
Waiting on contributor
| You can republish repository metadata when a repository distribution does not have the content that should be distributed based on the contents of the repository. | ||
|
|
||
| Use this procedure with caution. | ||
| {Team} recommends a complete repository sync or publishing a new content view version to repair broken metadata. |
There was a problem hiding this comment.
Should we avoid referencing CV since we are in the Republishing repository metadata by using CLI section?
| {Team} recommends a complete repository sync or publishing a new content view version to repair broken metadata. | |
| {Team} recommends a complete repository sync or metadata republish to repair broken metadata. |
There was a problem hiding this comment.
I think this is exactly the point: You should not really (need to) do this: republish repo metadata. That's why this line mentions either doing a complete re-sync or publishing a new CV version.
There was a problem hiding this comment.
I agree with Max. I suggest no change.
vsedmik
left a comment
vsedmik
left a comment
There was a problem hiding this comment.
Tested the CLI commands work good. One proposal to consider posted above ^
Lennonka
added
testing done
f3f2606 to
7950249
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
maximiliankolb
left a comment
maximiliankolb
left a comment
There was a problem hiding this comment.
Rebased to HEAD of "master" and applied one suggestion.
| You can republish repository metadata when a repository distribution does not have the content that should be distributed based on the contents of the repository. | ||
|
|
||
| Use this procedure with caution. | ||
| {Team} recommends a complete repository sync or publishing a new content view version to repair broken metadata. |
There was a problem hiding this comment.
I think this is exactly the point: You should not really (need to) do this: republish repo metadata. That's why this line mentions either doing a complete re-sync or publishing a new CV version.
Lennonka
added
style review done
|
I don't think this needs an additional tech ack. |
Lennonka
removed
the
Needs tech review
| + | ||
| [options="nowrap", subs="+quotes,attributes"] | ||
| ---- | ||
| $ hammer task list --search "Metadata generate repository" |
There was a problem hiding this comment.
This already shows the STATE and RESULT columns so why is another info below needed?
There was a problem hiding this comment.
Thanks Ewoud, good catch! It's not needed -> Dropped in both procedures. I would also like to search for this pattern in a follow-up PR in all other CLI modules.
This patch prepares the splitting the modules into WebUI and CLI procedures.
Tested on Foreman 3.14/Katello 4.16
Based on "proc_recovering-a-corrupted-repository.adoc".
7950249 to
f77a557
Compare
* Rename modules about republishing metadata This patch prepares the splitting the modules into WebUI and CLI procedures. * Add modules to republish metadata via CLI Tested on Foreman 3.14/Katello 4.16 * Add introduction to republishing CV metadata Based on "proc_recovering-a-corrupted-repository.adoc".
4 participants
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
CLI procedures were missing.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Republishing the metadata felt a bit weird to me. I would appreciate it if someone would rerun the commands on Foreman nightly or latest too.
Contributor checklists
Please cherry-pick my commits into: