Skip to content

Conversation

AkshayGadhaveRH
Copy link
Contributor

@AkshayGadhaveRH AkshayGadhaveRH commented Sep 30, 2025

Making the changes resulting from the DITA vale tests results in the JIRA: https://issues.redhat.com/browse/SAT-36307

What changes are you introducing?

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 30, 2025
@AkshayGadhaveRH
Copy link
Contributor Author

Working on changing the discrete headings.

@AkshayGadhaveRH AkshayGadhaveRH removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Sep 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Copy link
Member

@aneta-petrova aneta-petrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion on today's standup, I reviewed this PR. So far so good :) There is still some work remaining to resolve all the issues reported by asciidoctor-dita-vale messages (like the discrete headings mentioned in one of the previous comments) but this already brings us nice few steps closer to making the guide ready for migration!

@AkshayGadhaveRH AkshayGadhaveRH force-pushed the make_updating_guide_DITA_ready branch from 1aa0bc1 to 9b8e5bd Compare October 7, 2025 07:08
@aneta-petrova
Copy link
Member

Hi @AkshayGadhaveRH, just to check the expectations and next steps because as a reviewer, I'm not sure about them: I'm still seeing a few issues when running an asciidoctor-dita-vale check. So just a question: Are you running your own checks and thus are aware of the remaining issues? Or are you working with the report that's part of the Jira ticket? (Because the Vale reports that were originally uploaded to Jira are no longer up-to-date and we should run our own checks.)

@AkshayGadhaveRH AkshayGadhaveRH force-pushed the make_updating_guide_DITA_ready branch from 3f97a13 to 1faff20 Compare October 14, 2025 05:30
@AkshayGadhaveRH AkshayGadhaveRH force-pushed the make_updating_guide_DITA_ready branch from 950d4bc to 4324942 Compare October 14, 2025 10:22
@aneta-petrova
Copy link
Member

Hi Akshay, thanks for working on resolving the issues! I tried running asciidoctor-dita-vale on your PR and I get these three additional warnings. Are they on your radar?

 guides/common/modules/con_updating-project.adoc
 1:1  warning  Assign [role="_abstract"]       AsciiDocDITA.ShortDescription 
               to a paragraph to use it as                                   
               <shortdesc> in DITA.           
               
                guides/common/modules/proc_updating-foreman-server.adoc
 1:1  warning  Assign [role="_abstract"]       AsciiDocDITA.ShortDescription 
               to a paragraph to use it as                                   
               <shortdesc> in DITA.                                   
               
               guides/common/modules/proc_updating-smart-proxy-server.adoc
 1:1  warning  Assign [role="_abstract"]       AsciiDocDITA.ShortDescription 
               to a paragraph to use it as                                   
               <shortdesc> in DITA.                

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Oct 14, 2025
@Lennonka
Copy link
Contributor

Please, rebase your PR to get a clean build.

Also, we need these changes in Sat 6.18 as well -> I'm updating the cherry picks in description.

@AkshayGadhaveRH AkshayGadhaveRH force-pushed the make_updating_guide_DITA_ready branch from 4324942 to eba4fd9 Compare October 15, 2025 06:49
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Oct 15, 2025
Akshay Gadhave added 8 commits October 17, 2025 16:11
Making the changes resulting from the DITA vale tests results in the JIRA:
https://issues.redhat.com/browse/SAT-36307
Removed the discrete headings in the proc module by splitting the existing `Updating a disconnected Project Server on {EL} 9` chapter into two:
- Syncing the repositories on the connected Project Server
- Updating the disconnected Project Server
@AkshayGadhaveRH AkshayGadhaveRH force-pushed the make_updating_guide_DITA_ready branch from eba4fd9 to fb3566e Compare October 17, 2025 10:47

[id="Updating-Disconnected-{project-context}-on-EL9_{context}"]
= Updating a disconnected {ProjectServer} on {RHEL} 9
[id="preparing-repos-for-export_{context}"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[id="preparing-repos-for-export_{context}"]
[id="preparing-the-repositories-for-export"]

Please also adjust the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs style review Requires a review from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants