-
Notifications
You must be signed in to change notification settings - Fork 106
Make Updating guide ready for DITA migration #4314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make Updating guide ready for DITA migration #4314
Conversation
Working on changing the discrete headings. |
The PR preview for f68d5cf is available at theforeman-foreman-documentation-preview-pr-4314.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion on today's standup, I reviewed this PR. So far so good :) There is still some work remaining to resolve all the issues reported by asciidoctor-dita-vale messages (like the discrete headings mentioned in one of the previous comments) but this already brings us nice few steps closer to making the guide ready for migration!
1aa0bc1
to
9b8e5bd
Compare
guides/common/modules/proc_syncing-repos-on-the-connected-project.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_updating-the-disconnected-project.adoc
Outdated
Show resolved
Hide resolved
Hi @AkshayGadhaveRH, just to check the expectations and next steps because as a reviewer, I'm not sure about them: I'm still seeing a few issues when running an asciidoctor-dita-vale check. So just a question: Are you running your own checks and thus are aware of the remaining issues? Or are you working with the report that's part of the Jira ticket? (Because the Vale reports that were originally uploaded to Jira are no longer up-to-date and we should run our own checks.) |
guides/common/modules/proc_syncing-repos-on-the-connected-project.adoc
Outdated
Show resolved
Hide resolved
3f97a13
to
1faff20
Compare
950d4bc
to
4324942
Compare
Hi Akshay, thanks for working on resolving the issues! I tried running asciidoctor-dita-vale on your PR and I get these three additional warnings. Are they on your radar?
|
Please, rebase your PR to get a clean build. Also, we need these changes in Sat 6.18 as well -> I'm updating the cherry picks in description. |
4324942
to
eba4fd9
Compare
guides/common/modules/proc_synchronizing-repos-on-the-connected-project.adoc
Outdated
Show resolved
Hide resolved
Making the changes resulting from the DITA vale tests results in the JIRA: https://issues.redhat.com/browse/SAT-36307
Removed the discrete headings in the proc module by splitting the existing `Updating a disconnected Project Server on {EL} 9` chapter into two: - Syncing the repositories on the connected Project Server - Updating the disconnected Project Server
eba4fd9
to
fb3566e
Compare
|
||
[id="Updating-Disconnected-{project-context}-on-EL9_{context}"] | ||
= Updating a disconnected {ProjectServer} on {RHEL} 9 | ||
[id="preparing-repos-for-export_{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[id="preparing-repos-for-export_{context}"] | |
[id="preparing-the-repositories-for-export"] |
Please also adjust the file name.
Making the changes resulting from the DITA vale tests results in the JIRA: https://issues.redhat.com/browse/SAT-36307
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: