Skip to content

Conversation

aneta-petrova
Copy link
Member

What changes are you introducing?

Removing the keyword "Optional:" from a heading and moving it to the abstract.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

It seems that the element is causing an older downstream Satellite version. I'd like to change it in all versions for consistency.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 2, 2025
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Oct 2, 2025
Copy link
Contributor

@apinnick apinnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Oct 6, 2025
@aneta-petrova aneta-petrova merged commit 5a51656 into theforeman:master Oct 6, 2025
10 of 11 checks passed
@aneta-petrova aneta-petrova deleted the 38668_optional branch October 6, 2025 09:02
aneta-petrova added a commit that referenced this pull request Oct 6, 2025
(cherry picked from commit 5a51656)
(cherry picked from commit 1228c5e)
aneta-petrova added a commit that referenced this pull request Oct 6, 2025
(cherry picked from commit 5a51656)
(cherry picked from commit 1228c5e)
aneta-petrova added a commit that referenced this pull request Oct 6, 2025
(cherry picked from commit 5a51656)
(cherry picked from commit 1228c5e)
aneta-petrova added a commit that referenced this pull request Oct 6, 2025
aneta-petrova added a commit that referenced this pull request Oct 6, 2025
@aneta-petrova
Copy link
Member Author

Merged to "master" and cherry-picked:

e09806b..d7f6a7d 3.12 -> 3.12
99b40ad..692d460 3.13 -> 3.13
e78993c..8b7cb15 3.14 -> 3.14 (cherry-picked from 3.15)
a480b21..1228c5e 3.15 -> 3.15 (minor conflict)
f31c50c..6e638aa 3.16 -> 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants