[BUGFIX] Changed FacebookProviderException to extend IdentityProvider… #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Exception Co-Authored-By: Martin Heintze <[email protected]>
detrax
added a commit
to Leuchtfeuer/pxa_social_feed
that referenced
this pull request
Mar 6, 2023
shadowhand
approved these changes
Mar 8, 2023
|
@detrax as you can see from the tests, this alone is not enough to resolve the issue. |
KrohnMi
pushed a commit
to JAK0TA/pxa_social_feed
that referenced
this pull request
Apr 29, 2023
KrohnMi
pushed a commit
to JAK0TA/pxa_social_feed
that referenced
this pull request
Apr 29, 2023
KrohnMi
pushed a commit
to JAK0TA/pxa_social_feed
that referenced
this pull request
Apr 29, 2023
8 tasks
KrohnMi
pushed a commit
to JAK0TA/pxa_social_feed
that referenced
this pull request
Apr 29, 2023
KrohnMi
pushed a commit
to JAK0TA/pxa_social_feed
that referenced
this pull request
Apr 29, 2023
KrohnMi
pushed a commit
to JAK0TA/pxa_social_feed
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the FacebookProviderException to extend IdentityProviderException.
This way, a FacebookProviderException is also a IdentityProviderException and can be catched with ease - as it is also done in other implementations of oauth2-github, ...