Skip to content

Conversation

@martinbutt
Copy link

I ran into a problem today using a custom view that calls \Slim\Slim::getInstance();

There were a few others with the same issue here:
https://disqus.com/home/discussion/there4/unit_testing_slim_php_framework_applications_with_phpunit_26/

It just required adding $app->setName('default'); to LocalWebTestCase.

It looks like this was already added to WebTestCase::getSlimInstance(), but was not in the example code that overrides that.

@felixmaier1989
Copy link

I agree on the relevance of this line of code. I had to include it too im my own project.

By the way I think you should comply with this repo's coding standards, indentation in particular.

@martinbutt
Copy link
Author

@felixmaier1989, with the indentation, previously there was a mix of 2 and 4 spaces in the file. I've set it all to 4. Was there something I missed?

@felixmaier1989
Copy link

You are right indeed

@craig-davis
Copy link
Contributor

👍 @felixmaier1989 Want to pull this one in for us all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants