All vsftpd.conf parameters created and put in template file.#17
Open
bschonec wants to merge 4 commits intothias:masterfrom
bschonec:master
Open
All vsftpd.conf parameters created and put in template file.#17bschonec wants to merge 4 commits intothias:masterfrom bschonec:master
bschonec wants to merge 4 commits intothias:masterfrom
bschonec:master
Conversation
added 4 commits
September 22, 2015 12:08
…the params.pp file so that all of the values are the defaults based on man vsftpd.conf.
…odified the params.pp file so that all of the values are the defaults based on man vsftpd.conf." This reverts commit f76a847.
…ers to vsftp.conf.erb template file.
|
poke @thias - Are you still actively maintaining this module? Last update to this module was in 2014 so I'm wondering if you want/need someone else to maintain this module? |
|
@bschonec - I created a fork of this module and also merged your changes in to fork. But I've noticed that there are quite a few duplicate parameter entries in the template file. I'm updating the template to remove those. would you like a PR sent to you when its fixed? |
Author
|
Yeah, that'd be great. Looks like this project has gone stale. |
|
you can find your pr and my changes to fix some of the duplicate parameters + spec tests here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through 'man vsftpd.conf' and added any parameters that were missing from the module. Added those new parameters to the template file.
In addition, I changed the params.pp file so that any argument that isn't specified manually gets its default value set to whatever 'man vsftpd.conf' says it should be. Note that some of those values don't jive with what puppet-vsftpd module had so I made the default values according to the man page.
The arguments that I added will only be populated to vsftpd.conf file if they're not the default values (again according to man page).