fix: include gas parameters in mined transaction webhooks

[eabdelmoneim]

Previously gasLimit and gasPrice fields were null in mined transaction webhooks because the resolver functions only checked for "sent" status. Since MinedTransaction inherits gas fields from SentTransaction, these values should be available for mined transactions as well.

Updates the resolver functions to include "mined" status:

• resolveGas() - returns transaction.gas for sent/mined transactions
• resolveGasPrice() - returns transaction.gasPrice for sent/mined transactions
• resolveMaxFeePerGas() - returns transaction.maxFeePerGas for sent/mined transactions
• resolveMaxPriorityFeePerGas() - returns transaction.maxPriorityFeePerGas for sent/mined transactions

🤖 Generated with Claude Code

Changes

• Linear: https://linear.app/thirdweb/issue/INF-171/
• Here is the problem being solved.
• Here are the changes made.

How this PR will be tested

• Open the dashboard and click X. Result: A modal should appear.
• Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)

---

PR-Codex overview

This PR updates the logic in several functions to consider an additional transaction status, "mined", alongside "sent" when resolving gas-related values.

Detailed summary

• Modified resolveGas to return gas if transaction.status is "sent" or "mined".
• Updated resolveGasPrice to return gas price for "sent" or "mined" status.
• Changed resolveMaxFeePerGas to check for "sent" or "mined" status when resolving max fee.
• Altered resolveMaxPriorityFeePerGas to include "mined" status in its condition.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[coderabbitai]

Walkthrough

The conditional logic in four helper functions—resolveGas, resolveGasPrice, resolveMaxFeePerGas, and resolveMaxPriorityFeePerGas—was updated to return gas-related values when the transaction status is either "sent" or "mined", instead of only "sent". No changes were made to function signatures.

Changes

Cohort / File(s)	Change Summary
Transaction Gas Resolution Logic src/server/schemas/transaction/index.ts	Expanded conditional checks in four helper functions to include "mined" status alongside "sent" for returning gas-related values. No changes to function signatures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• INF-171: Entity not found: Issue - Could not find referenced Issue.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 067d5da and 22827e3.

📒 Files selected for processing (1)

• src/server/schemas/transaction/index.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build
• GitHub Check: lint
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (4)

src/server/schemas/transaction/index.ts (4)

279-284: LGTM! Gas parameter now correctly available for mined transactions.

The addition of the "mined" status check ensures that gasLimit will be populated in mined transaction webhooks, which directly addresses the reported issue.

---

286-291: LGTM! Consistent implementation for gasPrice parameter.

The change mirrors the pattern used in resolveGas and correctly handles the optional nature of gasPrice with appropriate null coalescing.

---

293-298: LGTM! EIP-1559 maxFeePerGas correctly handled for mined transactions.

The implementation is consistent with the other gas parameter resolvers and properly handles the EIP-1559 specific field.

---

300-305: LGTM! Complete and consistent fix for all gas parameters.

This final gas resolver change completes the consistent implementation across all four gas-related functions (resolveGas, resolveGasPrice, resolveMaxFeePerGas, resolveMaxPriorityFeePerGas), ensuring that all gas parameters are properly populated in mined transaction webhooks.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ea_missing_gas_params

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.