Skip to content

[Docs] Update pregenerate wallets API endpoint and request format #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Aug 5, 2025

Fixes BLD-47


PR-Codex overview

This PR updates the documentation for the wallets feature in the thirdweb portal, refining usage examples and correcting endpoint details for authentication and wallet pregeneration.

Detailed summary

  • Changed default tab from typescript to http in usage examples.
  • Added HTTP request examples for generic authentication.
  • Updated JWT placeholder from <your-jwt-token> to <your-jwt>.
  • Revised pregeneration endpoint and request body format.
  • Clarified wallet identifier types in the request body.
  • Adjusted curl command to reflect new endpoint and parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation
    • Updated wallet pregeneration API docs with a new endpoint, request format, and expanded identifier types.
    • Added explicit HTTP request examples for custom authentication strategies including JWT and auth endpoint.
    • Unified placeholder strings and improved example clarity across authentication documentation.
    • Clarified required HTTP headers and revised example requests and responses.
    • Made minor textual corrections for consistency.

Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2025 7:53pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nebula ⬜️ Skipped (Inspect) Aug 6, 2025 7:53pm
thirdweb_playground ⬜️ Skipped (Inspect) Aug 6, 2025 7:53pm
thirdweb-www ⬜️ Skipped (Inspect) Aug 6, 2025 7:53pm
wallet-ui ⬜️ Skipped (Inspect) Aug 6, 2025 7:53pm

@vercel vercel bot temporarily deployed to Preview – nebula August 5, 2025 02:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 5, 2025 02:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 5, 2025 02:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 5, 2025 02:43 Inactive
Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: 13eccc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 5, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The documentation for the wallet pregeneration API was updated to reflect a new endpoint, revised request and response formats, updated HTTP headers, and changes in parameter naming and allowed values. Example payloads and response structures were revised, and minor textual corrections were applied. Additionally, the custom authentication documentation was enhanced with new HTTP request examples for the jwt and auth_endpoint strategies, including updated JWT placeholder text and removal of redundant sentences.

Changes

Cohort / File(s) Change Summary
Wallet Pregeneration API Documentation
apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
Updated endpoint URL, HTTP headers, request/response formats, parameter names and allowed values, example payloads, and minor text corrections.
Custom Authentication Documentation
apps/portal/src/app/wallets/custom-auth/page.mdx
Added HTTP POST request examples for jwt and auth_endpoint strategies, updated JWT placeholder text, and removed redundant sentences in TypeScript examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Assessment against linked issues

Objective Addressed Explanation
Update pregenerate docs to point to the new API (BLD-47)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Addition of HTTP request examples and JWT placeholder updates in custom-auth documentation (apps/portal/src/app/wallets/custom-auth/page.mdx) These changes are unrelated to the pregenerate API update objective specified in BLD-47.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1d9564 and 13eccc9.

📒 Files selected for processing (2)
  • apps/portal/src/app/wallets/custom-auth/page.mdx (5 hunks)
  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
  • apps/portal/src/app/wallets/custom-auth/page.mdx
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _Docs_Update_pregenerate_wallets_API_endpoint_and_request_format

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Aug 5, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review August 5, 2025 02:44
@joaquim-verges joaquim-verges requested review from a team as code owners August 5, 2025 02:44
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.35%. Comparing base (9a3ebe1) to head (13eccc9).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7791      +/-   ##
==========================================
+ Coverage   56.34%   56.35%   +0.01%     
==========================================
  Files         905      905              
  Lines       58788    58796       +8     
  Branches     4141     4143       +2     
==========================================
+ Hits        33122    33135      +13     
+ Misses      25561    25556       -5     
  Partials      105      105              
Flag Coverage Δ
packages 56.35% <ø> (+0.01%) ⬆️
see 4 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

linear bot commented Aug 5, 2025

```
https://in-app-wallet.thirdweb.com/api/v1/pregenerate
```http
POST https://in-app-wallet.thirdweb.com/v1/wallets/user/pregenerate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API endpoint hostname in this example doesn't match the one used in the curl example below (line 99). For consistency, this should be updated to https://api.thirdweb.com/v1/wallets/user/pregenerate instead of https://in-app-wallet.thirdweb.com/v1/wallets/user/pregenerate to align with both the curl example and the updated endpoint mentioned in the PR description.

Suggested change
POST https://in-app-wallet.thirdweb.com/v1/wallets/user/pregenerate
POST https://api.thirdweb.com/v1/wallets/user/pregenerate

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"address": "string",
"createdAt": "string",
"profile": "object[]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of the profile field should be aligned with the address and createdAt fields for consistent formatting in the JSON response example. Consider adjusting to:

{
  "result": {
    "address": "string",
    "createdAt": "string",
    "profile": "object[]"
  }
}

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

```

### Custom user id based wallets

```
{ strategy: "custom_auth_endpoint", userId: "some_user_id" }
{ type: "custom_auth_endpoint", userId: "some_user_id" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in the parameter naming for custom user ID based wallets. In the request body description (line 60), the parameter is referred to as user, but in the example JSON (line 70), it's shown as userId. These should be aligned to provide clear documentation. Consider standardizing on one parameter name throughout the documentation.

Suggested change
{ type: "custom_auth_endpoint", userId: "some_user_id" }
{ type: "custom_auth_endpoint", user: "some_user_id" }

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
apps/portal/src/app/wallets/pregenerate-wallets/page.mdx (2)

123-127: Clarify profile field type

"profile": "object[]" reads as a string literal, not a JSON type. Use an array notation to prevent ambiguity.

-      "profile": "object[]"
+      "profile": [ /* user profile objects */ ]

36-36: Minor typo: duplicated word

wallet walletwallet

-To pregenerate an in-app or ecosystem wallet wallet, you can make a `POST` request to the following endpoint:
+To pregenerate an in-app or ecosystem wallet, you can make a `POST` request to the following endpoint:
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a3ebe1 and c1ee34b.

📒 Files selected for processing (1)
  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx (4 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
📚 Learning: applies to packages/thirdweb/src/wallets/** : eip-1193, eip-5792, eip-7702 standard support in walle...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Applied to files:

  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : support for in-app wallets (social/email login)...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)

Applied to files:

  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
📚 Learning: applies to test/src/test-wallets.ts : predefined test accounts are in `test/src/test-wallets.ts`...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to test/src/test-wallets.ts : Predefined test accounts are in `test/src/test-wallets.ts`

Applied to files:

  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : unified `wallet` and `account` interfaces in wallet ar...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture

Applied to files:

  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
📚 Learning: surface breaking changes prominently in pr descriptions...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions

Applied to files:

  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : smart wallets with account abstraction...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction

Applied to files:

  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
🪛 Gitleaks (8.27.2)
apps/portal/src/app/wallets/pregenerate-wallets/page.mdx

102-102: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)

Copy link
Contributor

github-actions bot commented Aug 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.16 KB (0%) 1.3 s (0%) 210 ms (+140.82% 🔺) 1.5 s
thirdweb (cjs) 352.95 KB (0%) 7.1 s (0%) 686 ms (+11.53% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 61 ms (+824.65% 🔺) 175 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 38 ms (+2616.83% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 19.26 KB (0%) 386 ms (0%) 62 ms (+588.83% 🔺) 447 ms

@joaquim-verges joaquim-verges force-pushed the _Docs_Update_pregenerate_wallets_API_endpoint_and_request_format branch from c1ee34b to b3d9076 Compare August 5, 2025 07:34
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 5, 2025 07:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 5, 2025 07:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 5, 2025 07:34 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula August 5, 2025 07:34 Inactive
@joaquim-verges joaquim-verges force-pushed the _Docs_Update_pregenerate_wallets_API_endpoint_and_request_format branch from b3d9076 to 5b8417b Compare August 5, 2025 07:50
@vercel vercel bot temporarily deployed to Preview – nebula August 5, 2025 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 5, 2025 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 5, 2025 07:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 5, 2025 07:50 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🔭 Outside diff range comments (1)
apps/portal/src/app/wallets/custom-auth/page.mdx (1)

97-103: Clarify “strategy” vs “type” naming difference.

In SDK snippets the property is still called strategy, whereas raw HTTP examples use type. If this is an intentional API/SDK divergence, add a one-liner explaining the difference; otherwise align the field names to prevent confusion.

🧹 Nitpick comments (1)
apps/portal/src/app/wallets/custom-auth/page.mdx (1)

32-33: Correct typo: “OICD” → “OIDC”.

The abbreviation is misspelled in the tab label, which can confuse readers searching the page for OIDC-related content.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3d9076 and 5b8417b.

📒 Files selected for processing (2)
  • apps/portal/src/app/wallets/custom-auth/page.mdx (5 hunks)
  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/src/app/wallets/pregenerate-wallets/page.mdx
🧰 Additional context used
🧠 Learnings (24)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : use `authorization: bearer` header – neve...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use `Authorization: Bearer` header – never embed tokens in URLs

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : eip-1193, eip-5792, eip-7702 standard support in walle...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : always call `getauthtoken()` to retrieve ...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Always call `getAuthToken()` to retrieve JWT from cookies on server side

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : support for in-app wallets (social/email login)...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Support for in-app wallets (social/email login)

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/api/**/*.{ts,tsx} : always call `getauthtoken()` to get the jwt from cookies...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/api/**/*.{ts,tsx} : Always call `getAuthToken()` to get the JWT from cookies.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to test/src/test-wallets.ts : predefined test accounts are in `test/src/test-wallets.ts`...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to test/src/test-wallets.ts : Predefined test accounts are in `test/src/test-wallets.ts`

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/api/**/*.{ts,tsx} : pass the token in the `authorization: bearer` header – n...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/api/**/*.{ts,tsx} : Pass the token in the `Authorization: Bearer` header – never embed it in the URL.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*client.tsx : create light wrappers (e.g. `fetchjson`) that automatically at...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Create light wrappers (e.g. `fetchJson`) that automatically attach the JWT from cookies/session when calling internal API routes.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : keep tokens secret via internal api route...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Keep tokens secret via internal API routes or server actions

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*client.tsx : interactive ui that relies on hooks (`usestate`, `useeffect`, ...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Interactive UI that relies on hooks (`useState`, `useEffect`, React Query, wallet hooks).

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : use `navlink` for internal navigation wit...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use `NavLink` for internal navigation with automatic active states in dashboard and playground apps

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*client.tsx : anything that consumes hooks from `@tanstack/react-query` or t...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Anything that consumes hooks from `@tanstack/react-query` or thirdweb SDKs.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*.{tsx,jsx} : prefer composable primitives over custom markup: `button`, `in...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Prefer composable primitives over custom markup: `Button`, `Input`, `Select`, `Tabs`, `Card`, `Sidebar`, `Separator`, `Badge`.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : import ui primitives from `@/components/u...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Import UI primitives from `@/components/ui/*` (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : use design system tokens (e.g., `bg-card`...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Use design system tokens (e.g., `bg-card`, `border-border`, `text-muted-foreground`)

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*.{tsx,jsx} : use `navlink` (`@/components/ui/navlink`) for internal navigat...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Use `NavLink` (`@/components/ui/NavLink`) for internal navigation so active states are handled automatically.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*client.tsx : pages requiring fast transitions where data is prefetched on t...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : Pages requiring fast transitions where data is prefetched on the client.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*.{ts,tsx} : redirect logic using `redirect()` from `next/navigation`....
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{ts,tsx} : Redirect logic using `redirect()` from `next/navigation`.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : wrap client-side data fetching calls in r...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to apps/{dashboard,playground-web}/**/*.{ts,tsx} : Wrap client-side data fetching calls in React Query (`@tanstack/react-query`)

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : unified `wallet` and `account` interfaces in wallet ar...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Unified `Wallet` and `Account` interfaces in wallet architecture

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to packages/thirdweb/src/wallets/** : smart wallets with account abstraction...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : Smart wallets with account abstraction

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: in the thirdweb/js project, the react namespace is available for type annotations (like react.fc) wi...
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
📚 Learning: applies to dashboard/**/*client.tsx : when you need access to browser apis (localstorage, window, in...
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*client.tsx : When you need access to browser APIs (localStorage, window, IntersectionObserver etc.).

Applied to files:

  • apps/portal/src/app/wallets/custom-auth/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Unit Tests
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/wallets/custom-auth/page.mdx (1)

72-74: Verify endpoint correctness (/generic-auth for JWT flow).

The JWT example points to
POST https://in-app-wallet.thirdweb.com/v1/wallets/user/generic-auth.

Is the JWT strategy really intended to hit the same generic-auth route, or should this be a dedicated /jwt-auth (or similar) endpoint? Confirm against the backend contract to avoid 4xx surprises.

@joaquim-verges joaquim-verges force-pushed the _Docs_Update_pregenerate_wallets_API_endpoint_and_request_format branch from 5b8417b to e1d9564 Compare August 5, 2025 07:55
@vercel vercel bot temporarily deployed to Preview – nebula August 5, 2025 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 5, 2025 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 5, 2025 07:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 5, 2025 07:55 Inactive
@joaquim-verges joaquim-verges force-pushed the _Docs_Update_pregenerate_wallets_API_endpoint_and_request_format branch from e1d9564 to 13eccc9 Compare August 6, 2025 19:45
@vercel vercel bot temporarily deployed to Preview – nebula August 6, 2025 19:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 6, 2025 19:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www August 6, 2025 19:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 6, 2025 19:45 Inactive
@joaquim-verges joaquim-verges merged commit 8bb2b0a into main Aug 6, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the _Docs_Update_pregenerate_wallets_API_endpoint_and_request_format branch August 6, 2025 20:49
Copy link

@Ari4ka Ari4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants