[SCAL-271696] feat: add axis-driven chart config support with validation #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ec10c93 |
abey-thomas
force-pushed
the
SCAL-271696
branch
2 times, most recently
from
3cd97d3 to
b167e33
Compare
abey-thomas
force-pushed
the
SCAL-271696
branch
5 times, most recently
from
ac7d276 to
2b09953
Compare
abey-thomas
changed the title
Add support for axis-driven chart config dimensions alongside existing column-driven configs. This enables more structured chart configurations with flat, merged, and dual axis types. Changes: - Add new AxisType enum (FLAT, MERGED, DUAL) and related config types - Add ChartConfigMode enum (COLUMN_DRIVEN, AXIS_DRIVEN) to support both modes - Implement chart config utility functions to extract query columns from both modes - Add validation functions to ensure chart config consistency - Integrate validation into CustomChartContext initialization - Add comprehensive test coverage (681 lines) for all config modes - Update mock implementations to use new utility functions - Export new utility functions in main index Breaking Changes: - Version bump to 2.6.0 due to new API surface area - ChartConfigDimension now supports both column-driven and axis-driven modes The new axis-driven mode allows for more complex chart configurations including merged columns (multiple columns in one axis slot) and dual axes (primary/secondary axis configurations).
abey-thomas
force-pushed
the
SCAL-271696
branch
from
2b09953 to
ec10c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAL-271696 feat: add axis-driven chart config support with validation
Add support for axis-driven chart config dimensions alongside existing
column-driven configs. This enables more structured chart configurations
with flat, merged, and dual axis types.
Changes:
Breaking Changes:
The new axis-driven mode allows for more complex chart configurations
including merged columns (multiple columns in one axis slot) and dual
axes (primary/secondary axis configurations).