SCAL-233969: Add preauth info call, emit Info call success event Iframe load#100
Merged
ajeet-lakhani-ts merged 10 commits intomainfrom Feb 19, 2025
Merged
Conversation
commit: |
utsavkapoor
approved these changes
Jan 27, 2025
…PreauthCache to control cache from Embed params
| } | ||
| try { | ||
| getPreauthInfo(); | ||
| const sessionInfo = await getSessionInfo(); |
Contributor
There was a problem hiding this comment.
Can we replace this getSessionInfo with the getPreauthInfo here? Better to avoid multiple api calls.
Contributor
There was a problem hiding this comment.
Or update the getSessionInfo to call getPreauthInfo internally and replace the dependency on old /info call
Collaborator
Author
There was a problem hiding this comment.
This is decided with TSE to keep both APIs as older customers won't have preauth info API. Check more detail here - https://thoughtspot.slack.com/archives/C082G97N8BZ/p1732810938126219
jbhanu-thoughtspot
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.