SCAL-265458 Added TSE controls showing spotter past conversations

[kumar935]

No description provided.

[mnk-blr]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

[gemini-code-assist]

Summary of Changes

Hello @kumar935, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature that allows for controlling the visibility of a 'past conversations sidebar' within the Spotter embed experience. It achieves this by adding a new configuration property to the embed view settings, which is then translated into a URL query parameter. This enhancement provides greater flexibility for integrators to customize the user interface of the embedded Spotter component.

Highlights

• New Configuration Option: A new configuration option, enablePastConversationsSidebar, has been introduced to the SpotterEmbedViewConfig interface. This boolean property allows developers to control the visibility of the past conversations sidebar within the embedded Spotter experience.
• Integration with SpotterEmbed: The SpotterEmbed class now processes the enablePastConversationsSidebar property from its view configuration. If this property is set, it will be translated into a corresponding query parameter (EnablePastConversationsSidebar) that is appended to the URL used to load the embedded Spotter instance.
• New Query Parameter Definition: The Param enum in src/types.ts has been updated to include EnablePastConversationsSidebar, ensuring that the new query parameter is properly defined and recognized within the SDK.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new control, enablePastConversationsSidebar, to the SpotterEmbed component, allowing the display of past conversations in a sidebar. The changes are well-implemented across the configuration and parameter handling. My feedback includes a suggestion to improve the JSDoc for the new property to enhance clarity and maintainability.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@279

commit: 6931025