Skip to content

Conversation

ruchI9897
Copy link
Contributor

No description provided.

@ruchI9897 ruchI9897 requested a review from a team as a code owner August 21, 2025 04:11
@mnk-blr
Copy link
Collaborator

mnk-blr commented Aug 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ruchI9897, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the documentation for the hiddenListColumns property within the HomePageConfig interface. The changes clarify the conditions under which this option is available, its current applicability to specific list pages, and its planned support for the Home page in a future version. The goal is to provide more accurate and comprehensive information for developers using this configuration.

Highlights

  • Documentation Clarity: The documentation for hiddenListColumns has been updated to explicitly state that it is currently available only in full app embedding and requires importing the ListPageColumns enum.
  • Feature Scope: The updated documentation now specifies that hiddenListColumns can presently be used with Liveboard and Answer list pages.
  • Future Compatibility: Information has been added indicating that hiddenListColumns will also be supported for the Home page starting with version 10.14.0.cl.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the hiddenListColumns option to provide more context on its usage. I've suggested a small refinement to the comment for improved clarity and to fix a minor formatting issue.

Comment on lines +1043 to +1044
* **Note**: This option is currently available only in full app embedding and requires importing the ListPageColumns enum.
* At present, it can be used with Liveboard and Answer list pages, and starting with version 10.14.0.cl, it will also be supported for the Home page.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This updated comment is helpful. It could be slightly improved for clarity and formatting. The first line has a trailing whitespace, and the second sentence could be phrased more directly.

Suggested change
* **Note**: This option is currently available only in full app embedding and requires importing the ListPageColumns enum.
* At present, it can be used with Liveboard and Answer list pages, and starting with version 10.14.0.cl, it will also be supported for the Home page.
* **Note**: This option is currently available only in full app embedding and requires importing the ListPageColumns enum.
* At present, it can be used with Liveboard and Answer list pages. Support for the Home page will be added in version 10.14.0.cl.

Copy link

pkg-pr-new bot commented Aug 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@290

commit: 6c75622

Copy link

sonar-prod-ts bot commented Aug 22, 2025

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ruchI9897 ruchI9897 merged commit 4465f6d into main Aug 22, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants