SCAL-269820 Add SDK flag to specifically control enablement of Downlo… #301
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @g-nitin-t, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the SDK by providing a dedicated configuration option to manage the XLSX/CSV download capability for embedded Liveboards. This allows developers to precisely control data export features, ensuring compliance and tailored user experiences within their integrated applications.
Highlights
- New SDK Flag for Download Control: Introduced a new SDK flag,
liveboardXLSXCSVDownload, to specifically enable or disable the XLSX/CSV download option for Liveboards within embedded applications. - Supported Embed Types: This new flag is supported by both
AppEmbedandLiveboardEmbedtypes, providing consistent control across different embedding scenarios. - URL Parameter Integration: The value of the
liveboardXLSXCSVDownloadflag is translated into a URL parameterisLiveboardXLSXCSVDownloadEnabledwhen constructing the iframe source, ensuring the backend respects the desired download setting. - Comprehensive Test Coverage: New unit tests have been added for both
AppEmbedandLiveboardEmbedto verify that theliveboardXLSXCSVDownloadflag correctly influences the generated URL parameters.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new SDK flag, liveboardXLSXCSVDownload, to control the download functionality for Liveboards. The implementation is sound and includes corresponding tests. My feedback focuses on improving code maintainability by reducing duplication in tests through parameterization, and enhancing consistency and clarity in the implementation by removing redundant checks and ensuring uniform handling of boolean flags. I've also suggested a small change to maintain the organizational structure of an enum.
commit: |
g-nitin-t
force-pushed
the
SCAL-269820
branch
from
70a1032 to
387a6a5
Compare
…ad XLS/CSV of a Liveboard for TSE use-cases
g-nitin-t
force-pushed
the
SCAL-269820
branch
from
387a6a5 to
c508baf
Compare
|
SonarQube Quality Gate
|
3 participants
Jira: https://thoughtspot.atlassian.net/browse/SCAL-268272