Added mixpanel events for CBCA #309
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @adityamittal3107, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances our analytics capabilities by introducing a new Mixpanel event to monitor the adoption and usage patterns of code-based custom actions within the embed SDK. This will provide valuable insights into how developers are leveraging this feature.
Highlights
- Mixpanel Event Tracking: Introduced a new Mixpanel event, CODE_BASED_CUSTOM_ACTION_COUNT, to track the number of code-based custom actions configured during application initialization.
- Custom Action Analytics: The event is triggered only when custom actions are present, sending the total count of actions for analytics purposes.
- Test Coverage: Added comprehensive unit tests to ts-embed.spec.ts to ensure the new Mixpanel event is correctly triggered (or not triggered) based on the presence and count of custom actions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
SonarQube Quality Gate
|
There was a problem hiding this comment.
Code Review
This pull request introduces Mixpanel event tracking for code-based custom actions. A new event, CODE_BASED_CUSTOM_ACTION_COUNT, is now sent during application initialization to record the usage of this feature. The changes include adding the new event type, implementing the tracking logic within getDefaultAppInitData, and adding corresponding unit tests to verify the functionality.
The implementation is solid, but I've suggested a small improvement to count only the valid custom actions for more accurate analytics. Overall, this is a valuable addition for monitoring feature adoption.
| if (customActions.length > 0) { | ||
| uploadMixpanelEvent(MIXPANEL_EVENT.CODE_BASED_CUSTOM_ACTION_COUNT, { | ||
| count: customActions.length, | ||
| }); | ||
| } |
There was a problem hiding this comment.
It's great that you're adding analytics for code-based custom actions. However, the current implementation sends the count of all custom actions provided, including potentially invalid ones. It would be more accurate and useful for analytics to track the number of valid custom actions that are actually processed and available to the user. You can achieve this by using customActionsResult.actions.length for both the condition and the count.
| if (customActions.length > 0) { | |
| uploadMixpanelEvent(MIXPANEL_EVENT.CODE_BASED_CUSTOM_ACTION_COUNT, { | |
| count: customActions.length, | |
| }); | |
| } | |
| if (customActionsResult.actions.length > 0) { | |
| uploadMixpanelEvent(MIXPANEL_EVENT.CODE_BASED_CUSTOM_ACTION_COUNT, { | |
| count: customActionsResult.actions.length, | |
| }); | |
| } |
commit: |
2 participants
No description provided.