-
Notifications
You must be signed in to change notification settings - Fork 6
Major Version Bump #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Version Bump #321
Conversation
Summary of ChangesHello @adityamittal3107, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's version number. The change reflects a transition to a new major version, which often implies the introduction of new features, significant improvements, or breaking changes, preparing the package for its next release cycle. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request increments the package version to 1.42.0. However, it is missing a critical update to CHANGELOG.md. For maintainability and clear release tracking, the changes under the 'Unreleased' section must be moved to a new section for version 1.42.0 within the same pull request. Additionally, the pull request title 'Major Version Bump' is inaccurate for a minor version increment and should be corrected to 'Minor Version Bump' to align with Semantic Versioning.
| { | ||
| "name": "@thoughtspot/visual-embed-sdk", | ||
| "version": "1.41.1", | ||
| "version": "1.42.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit: |
|
SonarQube Quality Gate |








No description provided.