SCAL-276900 Added action for liveboardStylePanel

[chinmay-ts]

Add LiveboardStylePanel Action to Visual Embed SDK

📋 Summary

This PR adds a new Action.LiveboardStylePanel enum value to the Visual Embed SDK, allowing developers to control the visibility of the Liveboard style panel in embedded.

[gemini-code-assist]

Summary of Changes

Hello @chinmay-ts, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Visual Embed SDK by integrating a new action that grants developers granular control over the display of the Liveboard style panel within embedded content. This addition provides more flexibility in customizing the user experience for embedded Liveboards.

Highlights

• New Action Added: Introduced a new Action.LiveboardStylePanel enum value to the Visual Embed SDK.
• Control Liveboard Style Panel Visibility: This new action allows developers to control the visibility of the Liveboard style panel in embedded contexts.
• Test Coverage: Added a new test case in src/embed/liveboard.spec.ts to verify that LiveboardStylePanel is correctly handled when specified in visibleActions.
• Type Definition Update: Updated src/types.ts to include the LiveboardStylePanel in the Action enum, complete with documentation and versioning information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Licenses	0	0	0	0	0 issues
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request adds a new Action.LiveboardStylePanel to control the visibility of the Liveboard style panel. The changes include adding the new enum value in src/types.ts and a corresponding test case in src/embed/liveboard.spec.ts.

My review focuses on improving the documentation clarity and test robustness. I've suggested a minor update to the TSDoc for the new action to improve consistency. I've also recommended refactoring the new test case to use an existing helper function, which will make it more readable and maintainable.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@327

commit: 1464c54

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication