SCAL-265458 Enable past conversation switch for TSE

[kumar935]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @kumar935, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SpotterEmbed component by introducing a new configuration option that allows for dynamic control over the visibility of the 'past conversations sidebar'. This feature provides greater flexibility for embedding ThoughtSpot content, enabling users to tailor the interface to their specific needs by either showing or hiding the sidebar through a simple boolean setting in the embed view configuration.

Highlights

• New Configuration Option: Introduced a new optional property, enablePastConversationsSidebar, to the SpotterEmbedViewConfig interface. This property allows control over the visibility of the past conversations sidebar within the embedded experience.
• Query Parameter Integration: The enablePastConversationsSidebar configuration option is now processed within the SpotterEmbed class and, if defined, is translated into a URL query parameter named enablePastConversationsSidebar.
• Enum Update: A new enum member, EnablePastConversationsSidebar, has been added to the Param enum in src/types.ts to represent the corresponding query parameter key.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Licenses	0	0	0	0	0 issues
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request enables a new enablePastConversationsSidebar option for SpotterEmbed. The implementation looks correct, adding the corresponding parameter to the embed URL. I've added one comment regarding the TSDoc for the new property, pointing out a minor formatting inconsistency and a potential versioning error that should be reviewed.

[gemini-code-assist]

The TSDoc for the new enablePastConversationsSidebar property has a couple of issues:

1. Formatting: There's an extra space before the colon in the property description (line 168) and in the example code (line 176). For consistency with other properties in this file, the format should be propertyName: description.
2. Version Number: The @version on line 179 is set to SDK: 1.36.0 | ThoughtSpot: 10.5.0.cl. This appears to be an old version, especially when compared to other recent additions (e.g., excludeRuntimeParametersfromURL is versioned 1.41.0). This might be a copy-paste error and could be misleading for SDK users. Please verify and update it to the correct version for this feature.

I've provided a suggestion to correct the formatting.

Suggested change

	/**
	* enablePastConversationsSidebar : Controls the visibility of the past conversations sidebar.
	*
	* Supported embed types: `SpotterEmbed`
	* @default false
	* @example
	* ```js
	* const embed = new SpotterEmbed('#tsEmbed', {
	* ... //other embed view config
	* enablePastConversationsSidebar : true,
	* })
	* ```
	* @version SDK: 1.36.0 | ThoughtSpot: 10.5.0.cl
	*/
	enablePastConversationsSidebar?: boolean;
	/**
	* enablePastConversationsSidebar: Controls the visibility of the past conversations sidebar.
	*
	* Supported embed types: `SpotterEmbed`
	* @default false
	* @example
	* ```js
	* const embed = new SpotterEmbed('#tsEmbed', {
	* ... //other embed view config
	* enablePastConversationsSidebar: true,
	* })
	* ```
	* @version SDK: 1.36.0 | ThoughtSpot: 10.5.0.cl
	*/
	enablePastConversationsSidebar?: boolean;

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@330

commit: 5397e32