SCAL-116040 host-event current iframe url #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sastaachar
reviewed
Sep 3, 2024
src/utils/processTrigger.ts
Outdated
| return res(null); | ||
| } | ||
| if (messageType === HostEvent.GetIframeSrc) { | ||
| return getIframeSrc(iFrame); |
There was a problem hiding this comment.
pass the result into res check above
also test it out in app embed , if route changes return proper urls
There was a problem hiding this comment.
yeah, right.
Will test in app embed
sastaachar
reviewed
Sep 3, 2024
src/utils/processTrigger.ts
Outdated
| reload(iFrame); | ||
| return res(null); | ||
| } | ||
| if (messageType === HostEvent.GetIframeSrc) { |
commit: |
src/types.ts
Outdated
| * const frameUrl = AppEmbed.trigger(HostEvent.GetIframeUrl) | ||
| * ``` | ||
| * @version SDK: 1.35.0 | Thoughtspot: 10.4.cl | ||
| * @hidden |
There was a problem hiding this comment.
Why @hidden tag is added?
There was a problem hiding this comment.
Removed, It's not available in docs, will raise one ticket for @ShashiSubramanya
src/types.ts
Outdated
| * ```js | ||
| * const frameUrl = AppEmbed.trigger(HostEvent.GetIframeUrl) | ||
| * ``` | ||
| * @version SDK: 1.35.0 | Thoughtspot: 10.4.cl |
There was a problem hiding this comment.
Thoughtspot version should be 10.4.0.cl
yinstardev
force-pushed
the
SCAL-116040
branch
from
516c468 to
ef44915
Compare
adityamittal3107
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.