Fix deps optimization warnings and include terser compressor #4395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0oM4R
requested review from
AhmedHanafy725,
Mahmoud-Emad,
MohamedElmdary,
amiraabouhadid and
zaelgohary
as code owners
zaelgohary
requested changes
Oct 27, 2025
Contributor
zaelgohary
left a comment
zaelgohary
left a comment
There was a problem hiding this comment.
Should Update the lock file too.
Contributor
|
Also, I still get the warnings. 
|
Contributor
Author
This is not related, the pr is for the yarn dev command, the warnings are related to eslint not the build |
Contributor
|
@0oM4R Please fix the security & codacy checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a fresh build, we may have some runtime warnings; it works after a refresh. This is due to the new Vite version. It is a known issue on Vite, so we exclude the complex deps to avoid this error
also added terser copressor