Skip to content

Conversation

@zaelgohary
Copy link
Contributor

Description

VAutocomplete's v-model:search two-way binding was causing circular updates. VAutocomplete internally syncs the search input with the selected item's name ("All Farms"), which overwrites user input after each keystroke.

Changes

  • Changed from 2-way binding to controlled search binding
  • Disabled built-in filtering which was interfering w our search
  • Added isClearing flag
  • Added new handleSearchUpdate w guards
  • Edited onClear
  • Updated farms computed property to match country filter behavior

Related Issues

0oM4R
0oM4R previously approved these changes Oct 22, 2025
@0oM4R 0oM4R dismissed their stale review October 22, 2025 11:22

need more tests

@0oM4R
Copy link
Contributor

0oM4R commented Oct 22, 2025

Screencast.from.2025-10-22.14-22-59.webm

On clear, the old value is kept I think the value should be cleared as well

@zaelgohary zaelgohary requested a review from 0oM4R October 22, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants