Skip to content

Conversation

@brentonhouse
Copy link
Contributor

@brentonhouse brentonhouse commented Aug 6, 2019

Add support for tag in View XML files that would simply output the code from the body of the element into the auto-generated controller.

JIRA Ticket: https://jira.appcelerator.org/browse/ALOY-1700

Code can be added by src attribute:

<Script src="/code/myfile.js" />

By body text:

<Script>
// this is a test
var a = 123;
</Script>

Or by both:

<Script src="/code/myfile.js">
// this is a test
var a = 123;
</Script>

In the last case, it will put the code from the source file above the code from the body text.

The code will then be added to the auto-generated code that is put into the JavaScript controller.

@brentonhouse brentonhouse changed the title Add support for <Code> tag in View XML files [ALOY-1700] Add support for <Code> tag in View XML files Aug 6, 2019
@brentonhouse brentonhouse requested a review from ewanharris August 6, 2019 19:02
@build
Copy link

build commented Aug 6, 2019

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header

Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against 4222349

@brentonhouse brentonhouse changed the title [ALOY-1700] Add support for <Code> tag in View XML files [ALOY-1700] Add support for <Script> tag in View XML files Oct 3, 2019
@brentonhouse brentonhouse self-assigned this Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants