Skip to content

Remove packageVersion("base") from tests #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

Remove packageVersion("base") from tests #6628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/testthat/test-annotate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ test_that("segment annotations transform with scales", {

test_that("annotation_* has dummy data assigned and don't inherit aes", {
skip_if_not_installed("maps")
skip_if(packageVersion("base") < "3.5.0")
custom <- annotation_custom(zeroGrob())
logtick <- annotation_logticks()
usamap <- map_data("state")
Expand Down
3 changes: 0 additions & 3 deletions tests/testthat/test-coord-map.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
test_that("USA state map drawn", {
skip_if_not_installed("mapproj") # required for coord_map()
skip_if_not_installed("maps") # required for map_data()
skip_if(packageVersion("base") < "3.5.0")
us_map <- map_data("usa")
p_us <- ggplot(us_map, aes(x = long, y = lat, group = group))
expect_doppelganger(
Expand All @@ -15,7 +14,6 @@ test_that("USA state map drawn", {
test_that("coord_map scale position can be switched", {
skip_if_not_installed("mapproj") # required for coord_map()
skip_if_not_installed("maps") # required for map_data()
skip_if(packageVersion("base") < "3.5.0")
us_map <- map_data("usa")
p_us <- ggplot(us_map, aes(x = long, y = lat, group = group))
expect_doppelganger(
Expand All @@ -31,7 +29,6 @@ test_that("coord_map scale position can be switched", {
test_that("Inf is squished to range", {
skip_if_not_installed("mapproj") # required for coord_map()
skip_if_not_installed("maps") # required for mproject()
skip_if(packageVersion("base") < "3.5.0")
d <- cdata(
ggplot(data_frame(x = 0, y = 0)) +
geom_point(aes(x,y)) +
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-geom-hline-vline-abline.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ test_that("check h/v/abline transformed on basic projections", {
test_that("curved lines in map projections", {
skip_if_not_installed("mapproj") # required for coord_map()
skip_if_not_installed("maps") # required for map_data()
skip_if(packageVersion("base") < "3.5.0")
nz <- subset(map_data("nz"), region == "North.Island ")
nzmap <- ggplot(nz, aes(long, lat, group = group)) +
geom_path() +
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-geom-quantile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
test_that("geom_quantile matches quantile regression", {
skip_if(packageVersion("base") < "3.6.0") # warnPartialMatchArgs didn't accept FALSE
withr::local_options(
warnPartialMatchArgs = FALSE,
warnPartialMatchDollar = FALSE
Expand Down
1 change: 0 additions & 1 deletion tests/testthat/test-geom-smooth.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ test_that("geom_smooth works in both directions", {
})

test_that("default smoothing methods for small and large data sets work", {
skip_if(packageVersion("base") < "3.6.0") # warnPartialMatchArgs didn't accept FALSE
withr::local_options(warnPartialMatchArgs = FALSE)
# Numeric differences on the MLK machine on CRAN makes these test fail
# on that particular machine
Expand Down
Loading