Align playground to newest tinkerbell #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the in-repo docs to align it with the tinkerbell.org docs. I've also replaced the instructions for deploying Tinkerbell in the Kubernetes quick start guide with a link to the tinkerbell.org Install guide, so we don't have the same info in too many places. I've also removed links to the example manifests, as they were not ported to the central repo. And again, best not to have the same info in too many places. Signed-off-by: Michael Meier <[email protected]>
This commit updates the playground to Tinkerbell's 0.19.0 release. The port of the HTTP server for HookOS changed, and the kubevip config in the values.yaml file of the Helm chart was moved under the optional: section. Signed-off-by: Michael Meier <[email protected]>
The tinkerbell.org install instructions now install the Helm chart into the tinkerbell namespace. This commit aligns the namespaces from the Install page and the playground to "tinkerbell". Signed-off-by: Michael Meier <[email protected]>
mmeier86
force-pushed
the
align-playground-to-newest-tinkerbell
branch
from
7d11d59 to
925d658
Compare
|
Let's keep this in draft for now, until the fix for tinkerbell/tinkerbell#261 in tinkerbell/tinkerbell#263 has been released, as the playground does not currently work with the |
Signed-off-by: Michael Meier <[email protected]>
1 task
|
I'm rerunning the tests with 0.19.2 now to see whether we can merge this PR with another update to use 0.19.2. |
Updating Tinkerbell to v0.19.2. This fixes the broadcast interface script issue in the 0.19.1 update. Signed-off-by: Michael Meier <[email protected]>
|
@jacobweinstock I've just run a full test of the playground, and it works fine with Tinkerbell v0.19.2. This PR can now be merged. Please also note tinkerbell/tinkerbell.org#257. It updates the tinkerbell.org Getting Started docs to reference the new namespace in the example |
jacobweinstock
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a couple of changes to align the playground examples with the newest Tinkerbell releases:
0.19.1tink-systemnamespace with thetinkerbellnamespace, aligning the playground examples with the newest Tinkerbell Helm chart install instructions from tinkerbell.orgWhy is this needed
Fixes: #211
How Has This Been Tested?
I've run through the playground setup steps with the libvirt provider and successfully provisioned
machine1.How are existing users impacted? What migration steps/scripts do we need?
There should be no existing user impact.
Checklist:
I have: