Fix device disconnect for windows #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it should be good, but I would defer to @jagobagascon or others with more Windows knowledge here, if anyone else would care to comment. |
|
Pinging Dr. @jagobagascon 😸 |
jagobagascon
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
I tried to replicate the issue with two different devices with no luck. So it seems that some devices are not affected by this issue.
But some of my colleagues reported that this PR fixes the issue for them (thanks for the hard work @sorayaormazabalmayo).
And I can confirm that my tests still work so the change looks good to me.
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues #247, #248
Added a
DeviceServicesubscription toDeviceDisconnectfunction call, that causesDeviceServiceClosefunction call.Tested personally, you can now reconnect to the device without restarting the process.