Skip to content

[Windows] Fix write respond #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

[Windows] Fix write respond #375

merged 1 commit into from
Jul 23, 2025

Conversation

maggch97
Copy link
Contributor

gattWriteRequest.Respond needs to be called if option is GattWriteOptionWriteWithResponse.

@maggch97 maggch97 force-pushed the fix_windows_write_respond branch from fbf8c2a to 087ff71 Compare July 18, 2025 05:34
@deadprogram deadprogram changed the base branch from release to dev July 21, 2025 18:57
@deadprogram
Copy link
Member

Switched target branch to dev as mentioned here: https://github.com/tinygo-org/bluetooth/blob/release/CONTRIBUTING.md#how-to-use-our-github-repository

@jagobagascon any thoughts on this PR?

jagobagascon
jagobagascon approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@jagobagascon jagobagascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and can confirm it works. LGTM

@deadprogram
Copy link
Member

Thanks for the improvement @maggch97 and to @jagobagascon for review. Now merging.

@deadprogram deadprogram merged commit 7042cf1 into tinygo-org:dev Jul 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagobagascon jagobagascon jagobagascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maggch97 @deadprogram @jagobagascon