-
Notifications
You must be signed in to change notification settings - Fork 219
Add PinInput and PinOutput HAL #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
What about #749 ? |
I missed that @deadprogram. Will comment |
I think around half of the work is done. On vacation this weekend so I'll get around sometime next week |
@@ -0,0 +1,83 @@ | |||
//go:build baremetal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baremetal
tags are used for when the implementation must use the machine.Pin
type to avoid user breakage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already use that buildtag in tinygo itself, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it for MCUs in TinyGo; is my understanding. So to let users use easystepper outside TinyGo I've split the implementation in baremetal and non-baremetal files protected with the baremetal tag.
OK! I just finished the brunt of the work. @aykevl @ysoldak @deadprogram @sago35 Tagging ready for review of the work done! |
machine.Pin
is not compileable by upstream go. To promote development of drivers which are usable by upstream Go I propose we add the following API.