Skip to content

reflect, runtime: additional Go 1.24 support #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Mar 2, 2025

Two major changes for Go 1.24 support:

  1. Removes package runtime dependency on package reflect, required for iter support in reflect.
  2. Copies the implementation of reflect.Value.Equal from big Go. This is necessary for JSON parsing in Go 1.24. See: https://go-review.googlesource.com/c/go/+/626116

@ydnar ydnar requested a review from aykevl March 2, 2025 23:34
@ydnar ydnar self-assigned this Mar 2, 2025
@ydnar ydnar marked this pull request as ready for review March 2, 2025 23:34
@aykevl
Copy link
Member

aykevl commented Mar 3, 2025

Unfortunately this requires the reflect package to be included in every build, which is not the case.

@deadprogram
Copy link
Member

Is it possible to use dd75c5c on its own? Can that help with decoding json leaving the iter issue to be resolved separately?

ydnar added 2 commits March 4, 2025 08:17
This is WIP, currently broken due to a cyclic import between packages reflect and runtime in TinyGo.
@ydnar
Copy link
Contributor Author

ydnar commented Mar 9, 2025

Closing in favor of #4787.

@ydnar ydnar closed this Mar 9, 2025
@ydnar ydnar deleted the ydnar/go1.24-reflect branch March 9, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants