Skip to content

reflect, internal/reflectlite: add Value.SetIter{Key,Value} and MapIter.Reset #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions src/internal/reflectlite/value.go
Original file line number Diff line number Diff line change
Expand Up @@ -1102,20 +1102,9 @@ func hashmapNewIterator() unsafe.Pointer
func hashmapNext(m unsafe.Pointer, it unsafe.Pointer, key, value unsafe.Pointer) bool

func (v Value) MapRange() *MapIter {
if v.Kind() != Map {
panic(&ValueError{Method: "MapRange", Kind: v.Kind()})
}

keyType := v.typecode.key()

keyTypeIsEmptyInterface := keyType.Kind() == Interface && keyType.NumMethod() == 0
shouldUnpackInterface := !keyTypeIsEmptyInterface && keyType.Kind() != String && !keyType.isBinary()

return &MapIter{
m: v,
it: hashmapNewIterator(),
unpackKeyInterface: shouldUnpackInterface,
}
iter := &MapIter{}
iter.Reset(v)
return iter
}

type MapIter struct {
Expand All @@ -1142,6 +1131,10 @@ func (it *MapIter) Key() Value {
return it.key.Elem()
}

func (v Value) SetIterKey(iter *MapIter) {
v.Set(iter.Key())
}

func (it *MapIter) Value() Value {
if !it.valid {
panic("reflect.MapIter.Value called on invalid iterator")
Expand All @@ -1150,6 +1143,10 @@ func (it *MapIter) Value() Value {
return it.val.Elem()
}

func (v Value) SetIterValue(iter *MapIter) {
v.Set(iter.Value())
}

func (it *MapIter) Next() bool {
it.key = New(it.m.typecode.Key())
it.val = New(it.m.typecode.Elem())
Expand All @@ -1158,6 +1155,23 @@ func (it *MapIter) Next() bool {
return it.valid
}

func (iter *MapIter) Reset(v Value) {
if v.Kind() != Map {
panic(&ValueError{Method: "MapRange", Kind: v.Kind()})
}

keyType := v.typecode.key()

keyTypeIsEmptyInterface := keyType.Kind() == Interface && keyType.NumMethod() == 0
shouldUnpackInterface := !keyTypeIsEmptyInterface && keyType.Kind() != String && !keyType.isBinary()

*iter = MapIter{
m: v,
it: hashmapNewIterator(),
unpackKeyInterface: shouldUnpackInterface,
}
}

func (v Value) Set(x Value) {
v.checkAddressable()
v.checkRO()
Expand Down
8 changes: 4 additions & 4 deletions src/reflect/all_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,6 @@ func TestSetValue(t *testing.T) {
}
}

/*

func TestMapIterSet(t *testing.T) {
m := make(map[string]any, len(valueTests))
for _, tt := range valueTests {
Expand Down Expand Up @@ -430,8 +428,6 @@ func TestMapIterSet(t *testing.T) {
}
}

*/

func TestCanIntUintFloatComplex(t *testing.T) {
type integer int
type uinteger uint
Expand Down Expand Up @@ -7955,6 +7951,8 @@ func TestConvertibleTo(t *testing.T) {
}
}

*/

func TestSetIter(t *testing.T) {
data := map[string]int{
"foo": 1,
Expand Down Expand Up @@ -8044,6 +8042,8 @@ func TestSetIter(t *testing.T) {
}
}

/*

func TestMethodCallValueCodePtr(t *testing.T) {
m := ValueOf(Point{}).Method(1)
want := MethodValueCallCodePtr()
Expand Down
12 changes: 12 additions & 0 deletions src/reflect/value.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,26 @@ func (it *MapIter) Key() Value {
return Value{((*reflectlite.MapIter)(it)).Key()}
}

func (v Value) SetIterKey(iter *MapIter) {
v.Value.SetIterKey((*reflectlite.MapIter)(iter))
}

func (it *MapIter) Value() Value {
return Value{((*reflectlite.MapIter)(it)).Value()}
}

func (v Value) SetIterValue(iter *MapIter) {
v.Value.SetIterValue((*reflectlite.MapIter)(iter))
}

func (it *MapIter) Next() bool {
return ((*reflectlite.MapIter)(it)).Next()
}

func (iter *MapIter) Reset(v Value) {
(*reflectlite.MapIter)(iter).Reset(v.Value)
}

func (v Value) Set(x Value) {
v.Value.Set(x.Value)
}
Expand Down