Repository navigation
reflect: add TypeAssert - #5160
Merged
Merged
Conversation
Member
Author
|
Hm, I can always flip it to the less optimal version if I don't figure out the deal here; perhaps the pointer arithmetic done in big Go does not apply to tinygo |
dgryski
requested changes
Jan 8, 2026
dgryski
left a comment
Member
There was a problem hiding this comment.
LGTM. Just needs to skip the panic test on wasi.
jakebailey
force-pushed
the
reflect-type-assert
branch
from
January 8, 2026 04:21
0a69cba to
77bb092
Compare
dgryski
reviewed
Jan 8, 2026
jakebailey
force-pushed
the
reflect-type-assert
branch
from
January 8, 2026 20:04
77bb092 to
67b8d02
Compare
Member
Author
I guess I should just log and return instead. |
jakebailey
force-pushed
the
reflect-type-assert
branch
from
January 8, 2026 20:37
67b8d02 to
9290ab5
Compare
Member
|
Thanks for the addition @jakebailey and to @dgryski for doing the reviewing. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was missing, leading to:
I ported the (theoreticlaly faster) reflectlite version of this, rather than just doing
v.Interface().(T), and copied the tests. I am not sure what's typical for this.