Skip to content

Conversation

TheRootDaemon
Copy link
Collaborator

@TheRootDaemon TheRootDaemon commented Jul 18, 2025

Addresses the issue #17234

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Closes: #17234

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages. labels Jul 18, 2025
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages.ko/common/manim.md:3: TLDR014 Page should contain no trailing whitespace

Please fix the error(s) and push again.

@TheRootDaemon
Copy link
Collaborator Author

I double-checked the More information: links in both pages.ko/common/manim.md and pages.zh/common/manim.md, and they match the English version (https://docs.manim.community).

But the bot has commented that there is a problem...

Can someone help ??

@Managor
Copy link
Member

Managor commented Jul 18, 2025

The More information text needs to match the text in the template page https://github.com/tldr-pages/tldr/blob/main/contributing-guides/translation-templates/more-info-link.md

@Managor Managor changed the title feat: tldr pages for the command manim manim: add page Jul 18, 2025
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@TheRootDaemon
Copy link
Collaborator Author

Hi @Managor,

  • I did use the template from the documentation: more-info-link.md.

  • I directly copied the "More information" from the docs into my pages, but the issue still persists.

  • And There are long options too, an example below

manim -pql {{path/to/file.py}} {{SceneName}}

manim --preview --quality low {{path/to/file.py}} {{SceneName}}

  • Is it preferred to use the long ones throughout the page instead of the short ones

@TheRootDaemon TheRootDaemon requested a review from Managor July 18, 2025 07:38
@TheRootDaemon TheRootDaemon requested a review from Managor July 18, 2025 09:43
@TheRootDaemon
Copy link
Collaborator Author

@Managor Manim does not have short options for commands such as --help, --list_scenes.

So the long ones were used intentionally.

@TheRootDaemon TheRootDaemon requested a review from Managor July 18, 2025 09:55
@Managor
Copy link
Member

Managor commented Jul 18, 2025

I know there is no short option, thus why use an option placeholder?

Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks alright

@Managor
Copy link
Member

Managor commented Jul 21, 2025

Please don't merge main when not needed. It creates unnecessary email spam.

@TheRootDaemon
Copy link
Collaborator Author

Okay, Sorry I didn't know that.

@Managor Managor merged commit d46ccf8 into tldr-pages:main Jul 26, 2025
4 checks passed
@TheRootDaemon TheRootDaemon deleted the manim branch July 26, 2025 14:10
Sarijen pushed a commit to Sarijen/tldr that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page request: manim
7 participants