feat(duckdb): Add transpilation support for neg position args for CHARINDEX#7334
Open
fivetran-amrutabhimsenayachit wants to merge 2 commits intomainfrom
Open
feat(duckdb): Add transpilation support for neg position args for CHARINDEX#7334fivetran-amrutabhimsenayachit wants to merge 2 commits intomainfrom
fivetran-amrutabhimsenayachit wants to merge 2 commits intomainfrom
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 72588 total, 71421 passed (pass rate: 98.4%), sqlglot version: sqlglot:RD-1147696-charindex: 72588 total, 71421 passed (pass rate: 98.4%), sqlglot version: Transitions: |
geooo109
reviewed
Mar 18, 2026
Comment on lines
+2566
to
+2571
| position = expression.args.get("position") | ||
| if ( | ||
| expression.args.get("clamp_position") | ||
| and position | ||
| and not (position.is_number and position.to_py() > 0) | ||
| ): |
Collaborator
There was a problem hiding this comment.
We should apply the logic on the transpiled query, right ?
WITH t as (select -1 as p) SELECT CHARINDEX('l', 'hello world', p) from t
We don't cover this ^ case. On parse time we don't know the value of p.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHARINDEX did not transpile as expected for neg position arg.
This PR fixes the same.