feat: Shorter log on property file not exists #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trace with java.io.FileNotFoundException is not usefull as it contains no additional information and only increases the log size. In qos-ch/logback this is implemented this way as well. See https://github.com/qos-ch/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/model/processor/PropertyModelHandler.java#L51
dzolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When property file included by configuration not exists then an ERROR log with long exception trace is populated.
The trace with
java.io.FileNotFoundExceptionis not useful as it contains no additional information and only increases the log size. This merge requests removed the trace from the ERROR log.Linked Issues
Additional context
In qos-ch/logback this is implemented this way as well. See https://github.com/qos-ch/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/model/processor/PropertyModelHandler.java#L51