dev to master sync #2
Conversation
Build error
…ts-api-v6 into develop
…ts-api-v6 into develop
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| # Connection string for the Members DB used by import:access | ||
| # Example: postgresql://postgres:postgres@localhost:5432/topcoder-services?schema=members | ||
| MEMBER_DB_URL="" |
There was a problem hiding this comment.
[💡 maintainability]
Consider providing a default or example value for MEMBER_DB_URL to ensure developers understand the expected format and reduce the risk of misconfiguration.
| with: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # The GITHUB_TOKEN is there by default so you just need to keep it like it is and not necessarily need to add it as secret as it will throw an error. [More Details](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret) | ||
| LAB45_API_KEY: ${{ secrets.LAB45_API_KEY }} | ||
| exclude: '**/*.json, **/*.md, **/*.jpg, **/*.png, **/*.jpeg, **/*.bmp, **/*.webp' # Optional: exclude patterns separated by commas No newline at end of file |
There was a problem hiding this comment.
[💡 style]
Consider adding a newline at the end of the file to adhere to POSIX standards, which can help avoid potential issues with some tools and version control systems.
| /dist | ||
| /node_modules | ||
| /build | ||
| dist |
There was a problem hiding this comment.
[💡 maintainability]
The entry dist is redundant because /dist already covers all directories named dist at any level. Consider removing the redundant entry to keep the .gitignore file clean.
| report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json | ||
|
|
||
| /generated/prisma | ||
| node_modules |
There was a problem hiding this comment.
[💡 maintainability]
The entry node_modules is redundant because /node_modules already covers all directories named node_modules at any level. Consider removing the redundant entry to keep the .gitignore file clean.
| ENV NODE_ENV production | ||
| ENV NODE_ENV=production | ||
| # Install OpenSSL runtime (provides libssl.so.3 for Prisma musl OpenSSL 3) | ||
| RUN apk add --no-cache openssl |
There was a problem hiding this comment.
[maintainability]
Consider specifying a version for the openssl package to ensure consistent builds. Without a version, future builds may break if a backward-incompatible change is introduced in openssl.
No description provided.