PM-1518 Fix 429 too many requests error #1170
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -11,6 +11,8 @@ const baseUrl = `${EnvironmentConfig.API.V5}/projects` | |||
|
|
|||
| export type ProjectsResponse = SWRResponse<Project[], Project[]> | |||
|
|
|||
| const sleep = (ms: number): Promise<()=> void> => new Promise(resolve => { setTimeout(resolve, ms) }) | |||
There was a problem hiding this comment.
The return type of the sleep function is incorrect. It should be Promise<void> instead of Promise<()=> void>. The function resolves without returning any value, so the correct type should reflect that.
| const allResults: Project[] = [] | ||
|
|
||
| for (const chunkIds of idChunks) { | ||
| // eslint-disable-next-line no-await-in-loop |
There was a problem hiding this comment.
Consider removing the // eslint-disable-next-line no-await-in-loop comment and refactoring the code to avoid using await inside a loop. This can be achieved by using Promise.all with map to handle asynchronous operations concurrently, which can improve performance.
| allResults.push(...response) | ||
|
|
||
| // Rate limit: delay 200ms between calls | ||
| // eslint-disable-next-line no-await-in-loop |
There was a problem hiding this comment.
The // eslint-disable-next-line no-await-in-loop comment indicates a potential issue with using await inside a loop. Consider refactoring the code to avoid this pattern, possibly by using Promise.all to handle asynchronous operations concurrently.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1518
What's in this PR?
Use sleep to introduce delays between chunked requests.
Sequentially fetch chunks with a delay (200ms) between requests.