fix(PM-1610): Updated toast message and tooltip copy for directly accepting copilot #1178
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -20,4 +20,5 @@ export interface CopilotApplication { | |||
| opportunityStatus: string, | |||
| existingMembership?: ExistingMembership, | |||
| projectName: string, | |||
| onApplied: () => void, | |||
There was a problem hiding this comment.
The addition of the onApplied function property to the CopilotApplication interface should include a description of its purpose and usage in the context of the application. Ensure that this function is implemented and utilized correctly wherever the CopilotApplication interface is used.
| @@ -1,9 +1,8 @@ | |||
| import { useParams } from 'react-router-dom' | |||
| import { toast } from 'react-toastify' | |||
| import { mutate } from 'swr' | |||
| import { useCallback, useMemo, useState } from 'react' | |||
There was a problem hiding this comment.
The removal of the mutate import suggests that it is no longer used in this file. Ensure that any related functionality relying on mutate is either updated or removed to prevent potential issues.
| toast.success('Invited a copilot') | ||
| mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`) | ||
| toast.success('Accepted as copilot') | ||
| copilotApplication.onApplied() |
There was a problem hiding this comment.
The mutate function call has been removed. Ensure that the removal of this line does not affect the application's state management or data fetching logic. If this line was responsible for revalidating or updating the cache, consider implementing an alternative approach to maintain the application's data consistency.
| @@ -56,7 +55,7 @@ const CopilotApplicationAction = ( | |||
|
|
|||
| await assignCopilotOpportunity(opportunityId, copilotApplication.id) | |||
| toast.success('Accepted as copilot') | |||
| mutate(`${copilotBaseUrl}/copilots/opportunity/${opportunityId}/applications`) | |||
| copilotApplication.onApplied() | |||
There was a problem hiding this comment.
The line copilotApplication.onApplied() replaces the previous mutate function call. Ensure that onApplied() correctly handles the cache update or any necessary side effects that mutate was performing. If onApplied() does not handle these, consider maintaining the mutate call or implementing the necessary logic within onApplied().
| @@ -85,6 +86,7 @@ const CopilotApplications: FC<{ | |||
| activeProjects: member?.activeProjects || 0, | |||
| fulfilment: member?.copilotFulfillment || 0, | |||
| handle: member?.handle, | |||
| onApplied: props.onApplied, | |||
There was a problem hiding this comment.
The addition of onApplied: props.onApplied seems to be a new property being passed to the component. Ensure that onApplied is defined and used appropriately within the component to avoid potential runtime errors.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1610
What's in this PR?