Have admin access be priority over resource role on challenge, and fix visibility of checkpoint submissions that fail screening #1311
Conversation
…x visibility of checkpoint submissions that fail screening
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| reviewEntries: reviewsToRender, | ||
| }) | ||
|
|
||
| const hasCheckpointReview = rowsForSubmission.some(row => Boolean(row.reviewId)) |
There was a problem hiding this comment.
[correctness]
The variable hasCheckpointReview is determined by checking if any row in rowsForSubmission has a reviewId. Ensure that rowsForSubmission is correctly populated with the expected data before this check, as any issues in data population could lead to incorrect logic execution.
| .toString() | ||
| .trim() | ||
| .toUpperCase() | ||
| const failedCheckpointScreening = submissionStatus === 'FAILED_CHECKPOINT_SCREENING' |
There was a problem hiding this comment.
[💡 maintainability]
The logic for determining failedCheckpointScreening relies on the status being exactly 'FAILED_CHECKPOINT_SCREENING'. Consider using a constant or enum for status values to avoid potential typos and improve maintainability.
| .toUpperCase() | ||
| const failedCheckpointScreening = submissionStatus === 'FAILED_CHECKPOINT_SCREENING' | ||
|
|
||
| if (failedCheckpointScreening && !hasCheckpointReview) { |
There was a problem hiding this comment.
[design]
The condition failedCheckpointScreening && !hasCheckpointReview results in an early return of rows. Ensure that this logic aligns with the intended behavior, as it skips adding rowsForSubmission to rows, which might be necessary for other parts of the application.
| const normalizedRoles = myRoles.map(role => role.toLowerCase()) | ||
| const normalizedRoles = [ | ||
| ...myRoles.map(role => role.toLowerCase()), | ||
| ...(isTopcoderAdmin ? ['admin'] : []), |
There was a problem hiding this comment.
[correctness]
The addition of admin to normalizedRoles when isTopcoderAdmin is true could potentially lead to a mismatch in role priority if the casing of roles is inconsistent elsewhere. Ensure that all role comparisons are case-insensitive to avoid unexpected behavior.
No description provided.