fix(PM-3065, PM-3074, PM-3076): added back button, ui issues #1347
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| flex-shrink: 0; | ||
| height: 20px; | ||
| width: 20px; | ||
| @include ltemd { |
There was a problem hiding this comment.
[❗❗ correctness]
Ensure that the ltemd mixin is defined and behaves as expected. If it's not defined in this file, verify its definition elsewhere to confirm it applies the intended styles correctly.
| try { | ||
| if (challengeInfo?.id) { | ||
| // Ensure the challenge details reflect the latest data (e.g., active phase) | ||
| await mutate(`challengeBaseUrl/challenges/${challengeInfo?.id}`) |
There was a problem hiding this comment.
[❗❗ correctness]
The mutate function is called with a hardcoded string challengeBaseUrl/challenges/${challengeInfo?.id}. Ensure that challengeBaseUrl is defined and correctly imported or used here, as it is not shown in the diff. If it's a typo or missing import, it could lead to runtime errors.
|
|
||
| const pastPrefix = '/past-challenges/' | ||
| // eslint-disable-next-line no-restricted-globals | ||
| const idx = location.pathname.indexOf(pastPrefix) |
There was a problem hiding this comment.
[correctness]
Using location.pathname directly can be problematic in environments where location is not defined, such as during server-side rendering. Consider using a safer method to access the current path that is compatible with both client and server environments.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-3065
https://topcoder.atlassian.net/browse/PM-3074
https://topcoder.atlassian.net/browse/PM-3076
What's in this PR?