Switch to auth headers #10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { | ||
| Injectable, | ||
| CanActivate, | ||
| ExecutionContext, | ||
| ForbiddenException, | ||
| BadRequestException, | ||
| InternalServerErrorException, | ||
| } from '@nestjs/common'; | ||
| import { Request } from 'express'; | ||
| import { LoggerService } from '../modules/global/logger.service'; | ||
|
|
||
| @Injectable() | ||
| export class GiteaWebhookAuthGuard implements CanActivate { | ||
| private readonly logger = LoggerService.forRoot('GiteaWebhookAuthGuard'); | ||
|
There was a problem hiding this comment. Consider using dependency injection for the LoggerService instead of calling |
||
|
|
||
| canActivate(context: ExecutionContext): boolean { | ||
| const request = context.switchToHttp().getRequest<Request>(); | ||
| const delivery = request.headers['x-gitea-delivery'] as string; | ||
| const event = request.headers['x-gitea-event'] as string; | ||
| const authHeader = request.headers['authorization'] as string; | ||
|
|
||
| // Check if GITEA_WEBHOOK_AUTH is configured | ||
| const auth = process.env.GITEA_WEBHOOK_AUTH; | ||
|
There was a problem hiding this comment. It might be more secure to use a configuration service or a secrets manager to handle sensitive environment variables like |
||
| if (!auth) { | ||
| this.logger.error( | ||
| 'GITEA_WEBHOOK_AUTH environment variable is not configured', | ||
| ); | ||
| throw new InternalServerErrorException('Webhook auth not configured'); | ||
| } | ||
|
|
||
| if (!delivery) { | ||
| this.logger.error('Missing X-Gitea-Delivery header'); | ||
| throw new BadRequestException('Missing delivery header'); | ||
| } | ||
|
|
||
| if (!event) { | ||
| this.logger.error('Missing X-Gitea-Event header'); | ||
| throw new BadRequestException('Missing event header'); | ||
| } | ||
|
|
||
| try { | ||
| // Validate the authorization header | ||
| if (!authHeader) { | ||
| this.logger.error('Missing Authorization header'); | ||
| throw new BadRequestException('Missing authorization header'); | ||
| } | ||
|
|
||
| if (authHeader !== `Bearer ${auth}`) { | ||
|
There was a problem hiding this comment. Consider using a more secure method for comparing the authorization header, such as a constant-time comparison function, to prevent timing attacks. |
||
| this.logger.error('Invalid authorization header'); | ||
| throw new ForbiddenException('Invalid authorization'); | ||
| } | ||
|
|
||
| this.logger.log( | ||
| `Valid webhook authorization verified for delivery ${delivery}, event ${event}`, | ||
| ); | ||
| return true; | ||
| } catch (error) { | ||
| if ( | ||
| error instanceof ForbiddenException || | ||
| error instanceof BadRequestException | ||
| ) { | ||
| throw error; | ||
| } | ||
|
|
||
| this.logger.error(`Error validating webhook signature: ${error.message}`); | ||
| throw new InternalServerErrorException('Signature validation failed'); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming the environment variable
GITEA_WEBHOOK_AUTHto something more descriptive if it is intended to store an authentication header value, asAUTHmight be too generic and could lead to confusion.