Submissions api integration #13

billsedison · 2025-08-05T12:44:39Z

No description provided.

github-actions · 2025-08-05T12:59:26Z

pnpm-lock.yaml

+  [email protected]:
+    resolution: {integrity: sha512-wkvS7mL/JMugcup3/rMitHmd9ecIGd2lhFhK9N3UUQ450h66d1r3Y9nvXzQAW1Lq+wyx61k/1pfKS5KuKiyEbg==}
+    engines: {node: '>=0.4.x'}
+    deprecated: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.


The querystring package is marked as deprecated. Consider replacing it with the URLSearchParams API to ensure future compatibility and to adhere to best practices.

github-actions · 2025-08-05T12:59:39Z

prisma/migrate.ts

+  return numA - numB;
+};
+
+function convertSubmissionES(esData): any {


Specifying any as the return type for convertSubmissionES can lead to potential type safety issues. Consider defining a more specific return type to improve type safety and maintainability.

github-actions · 2025-08-05T12:59:42Z

prisma/migrate.ts

+      if (source['resource'] === 'submission') {
+        await handleElasticSearchSubmission(source);
+      }
+    } catch {


Catching errors without specifying the error variable can make debugging difficult. Consider including the error variable in the catch block to log or handle specific errors more effectively.

github-actions · 2025-08-05T12:59:46Z

prisma/migrate.ts

+          },
+        });
+      }
+    } catch {


Catching errors without specifying the error object can make debugging difficult. Consider adding the error object back to the catch block to log or handle specific errors.

github-actions · 2025-08-05T12:59:50Z

prisma/migrate.ts

+    await prisma.upload.createMany({
+      data: uploadDataList,
+    });
+  } catch {


Consider adding error handling logic to the catch block to handle specific errors or log additional information. Currently, the catch block is empty, which might make it difficult to diagnose issues.

github-actions · 2025-08-05T12:59:50Z

prisma/migrate.ts

+    for (const u of uploadDataList) {
+      try {
+        await prisma.upload.create({ data: u });
+      } catch {


Consider adding error handling logic to the catch block to handle specific errors or log additional information. Currently, the catch block is empty, which might make it difficult to diagnose issues.

github-actions · 2025-08-05T12:59:53Z

prisma/migrate.ts

+    await prisma.submission.createMany({
+      data: submissionDataList,
+    });
+  } catch {


Consider logging the error object in the catch block to provide more context about the failure. This can help with debugging and understanding why the submission creation failed.

github-actions · 2025-08-05T12:59:59Z

prisma/migrate.ts

+      // collect data to uploadSubmissionMap
+      if (
+        dbData.status === SubmissionStatus.ACTIVE &&
+        dbData.legacyUploadId != null


Consider using strict equality checks (=== and !==) instead of loose equality checks (== and !=) for better type safety and to avoid unexpected type coercion.

github-actions · 2025-08-05T12:59:59Z

prisma/migrate.ts

+          const existing = uploadSubmissionMap[dbData.legacyUploadId];
+          if (
+            !existing.score ||
+            item.created.getTime() > existing.created.getTime()


Ensure that item.created and existing.created are both valid Date objects before calling getTime() to prevent potential runtime errors.

github-actions · 2025-08-05T13:00:04Z

prisma/migrate.ts

+async function doImportResourceSubmission() {
+  try {
+    await prisma.resourceSubmission.createMany({
+      data: resourceSubmissions,


Consider adding an error parameter to the catch block to log more detailed error information. This can help in diagnosing the issue more effectively.

github-actions · 2025-08-05T13:00:04Z

prisma/migrate.ts

+        await prisma.resourceSubmission.create({
+          data: rs,
+        });
+      } catch {


Consider adding an error parameter to the catch block to log more detailed error information. This can help in diagnosing the issue more effectively.

github-actions · 2025-08-05T13:00:20Z

src/api/contact/contactRequests.controller.ts

@@ -1,4 +1,4 @@
-import { Controller, Post, Body } from '@nestjs/common';
+import { Controller, Post, Body, Req } from '@nestjs/common';


The Req import from @nestjs/common is added, but it is not used in the current code. Consider removing it if it is not needed to avoid unnecessary imports.

github-actions · 2025-08-05T13:00:23Z

src/api/contact/contactRequests.controller.ts

@@ -16,15 +16,20 @@ import {
  mapContactRequestToDto,
 } from 'src/dto/contactRequest.dto';
 import { PrismaService } from '../../shared/modules/global/prisma.service';
+import { ResourceApiService } from 'src/shared/modules/global/resource.service';
+import { JwtUser } from 'src/shared/modules/global/jwt.service';

 @ApiTags('Contact Requests')
 @ApiBearerAuth()
 @Controller('/')


The change from @Controller('/api') to @Controller('/') might affect the routing of the API endpoints. Ensure that this change is intentional and that it aligns with the overall API structure.

github-actions · 2025-08-05T13:00:23Z

src/api/contact/contactRequests.controller.ts


  @Post('/contact-requests')
-  @Roles(UserRole.Submitter, UserRole.Reviewer)
+  @Roles(UserRole.User, UserRole.Talent)


The roles have been changed from UserRole.Submitter, UserRole.Reviewer to UserRole.User, UserRole.Talent. Verify that these roles are correct for the intended functionality and that they have the necessary permissions for creating contact requests.

github-actions · 2025-08-05T13:00:26Z

src/api/contact/contactRequests.controller.ts

    @Body() body: ContactRequestDto,
  ): Promise<ContactRequestResponseDto> {
+    const authUser: JwtUser = req['user'] as JwtUser;


Consider adding error handling for the case where req['user'] might not be defined or might not be of type JwtUser. This will help prevent runtime errors if the request does not contain a valid user object.

github-actions · 2025-08-05T13:00:27Z

src/api/contact/contactRequests.controller.ts

    @Body() body: ContactRequestDto,
  ): Promise<ContactRequestResponseDto> {
+    const authUser: JwtUser = req['user'] as JwtUser;
+    await this.resourceApiService.validateResourcesRoles(


The method validateResourcesRoles should ideally handle exceptions or return a meaningful error if the validation fails. Ensure that any errors thrown by this method are caught and handled appropriately to provide a clear response to the client.

github-actions · 2025-08-05T13:01:20Z

src/api/submission/submission.service.ts

+    return data;
+  }
+
+  private buildResponse(data: any): SubmissionResponseDto {


Consider specifying a more precise type than any for the data parameter to improve type safety and maintainability.

github-actions · 2025-08-05T13:01:48Z

src/shared/enums/userRole.enum.ts

@@ -7,4 +7,5 @@ export enum UserRole {
  Reviewer = 'reviewer',
  Submitter = 'Submitter',


Consider using consistent casing for enum values. The value 'Submitter' should be changed to 'submitter' to match the casing of other values like 'reviewer' and 'Talent'.

github-actions · 2025-08-05T13:01:49Z

src/shared/enums/userRole.enum.ts

@@ -7,4 +7,5 @@ export enum UserRole {
  Reviewer = 'reviewer',
  Submitter = 'Submitter',
  User = 'Topcoder User',
+  Talent = 'Topcoder Talent',


Ensure that the new enum value 'Talent' is used consistently across the application. Verify that any logic dependent on user roles is updated to include this new role.

github-actions · 2025-08-05T13:02:11Z