fix(PM-1503): Open view score card as public API #17
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, | ||
| }); | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/require-await | ||
| async cloneScorecard(id: string): Promise<ScorecardResponseDto> { |
There was a problem hiding this comment.
The cloneScorecard function has been heavily commented out, which makes it non-functional. If this is intentional for the purpose of this PR, consider removing the function entirely or providing an alternative implementation that aligns with the new public API requirements.
| // }, | ||
| // }, | ||
| // }); | ||
| const clonedScorecard = {}; |
There was a problem hiding this comment.
The clonedScorecard is currently an empty object. Ensure that this aligns with the intended functionality of the public API. If the function is supposed to return a meaningful response, consider implementing the necessary logic to populate clonedScorecard appropriately.
There was a problem hiding this comment.
We shouldn't have commented out code sections. Please update @hentrymartin.
@kkartunov yeah I had a chat with @vas3a, he said he will fix this that's why commented(without commenting, its not getting deployed in dev environment). @vas3a Please let me know if this is fixed, I will rebase it from feat/scorecards branch. |
|
@kkartunov can we merge this as is for now? Indeed I have an update in my branch for it, but it isn't ready to be pushed/merged. |
@kkartunov Keeping this in mind, can I merge this now? |
|
@hentrymartin OK. Merging this now and we will follow up when @vas3a rises his PR. Thanks. |
What's in this PR?