Skip to content

Handled track and type object after challenge save #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Handled track and type object after challenge save #1685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/components/ChallengeEditor/ChallengeReviewer-Field/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,21 @@ class ChallengeReviewerField extends Component {

// Add challenge track if available
if (challenge.track) {
filters.challengeTrack = challenge.track.toUpperCase().replace(' ', '_')

if (typeof challenge.track === 'string') {
filters.challengeTrack = challenge.track.toUpperCase().replace(' ', '_')
} else if (challenge.track.track) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a fallback or default value for filters.challengeTrack in case challenge.track is neither a string nor an object with a track property.

filters.challengeTrack = challenge.track.track
}
}

// Add challenge type if available
if (challenge.type) {
filters.challengeType = challenge.type
if (typeof challenge.type === 'string') {
filters.challengeType = challenge.type
} else if (challenge.type.name) {
filters.challengeType = challenge.type.name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a fallback or default value for filters.challengeType in case challenge.type is neither a string nor an object with a name property.

}
}

loadScorecards(filters)
Expand Down