fix(PM-2353): reset filter on viewing list view #1688
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| openChallengeView (challenge) { | ||
| this.props.setActiveProject(parseInt(challenge.projectId)) |
There was a problem hiding this comment.
The openChallengeView method should be bound to this in the constructor if it is intended to be used as an event handler or passed around as a callback. This ensures the correct this context is maintained.
| } | ||
|
|
||
| openChallengeView (challenge) { | ||
| this.props.setActiveProject(parseInt(challenge.projectId)) |
There was a problem hiding this comment.
Consider adding error handling for the parseInt(challenge.projectId) call to ensure that challenge.projectId is a valid number and handle cases where it might not be.
| </div> | ||
|
|
||
| <Link className={styles.col2} to={`/projects/${challenge.projectId}/challenges/${challenge.id}/view`} onClick={() => setActiveProject(parseInt(challenge.projectId))}> | ||
| <Link className={styles.col2} to={`/projects/${challenge.projectId}/challenges/${challenge.id}/view`} onClick={() => this.openChallengeView(challenge)}> |
There was a problem hiding this comment.
The function openChallengeView is being called with challenge as an argument. Ensure that openChallengeView is defined and handles the challenge parameter correctly. If openChallengeView is not defined within this component, it should be imported or defined appropriately.
| !isReadOnly && ( | ||
| <div className={styles.col6}> | ||
| {(disableHover ? <Link className={styles.link} to={`/projects/${challenge.projectId}/challenges/${challenge.id}/edit`}>Edit</Link> : hoverComponents(challenge, this.onUpdateLaunch, this.deleteModalLaunch))} | ||
| {(disableHover ? <Link className={styles.link} to={`/projects/${challenge.projectId}/challenges/${challenge.id}/edit`} onClick={() => this.props.resetFilter()}>Edit</Link> : hoverComponents(challenge, this.onUpdateLaunch, this.deleteModalLaunch))} |
There was a problem hiding this comment.
Consider checking if this.props.resetFilter is defined before calling it to prevent potential runtime errors if the prop is not passed correctly. For example: onClick={() => this.props.resetFilter && this.props.resetFilter()}.
| auth: PropTypes.object.isRequired, | ||
| loginUserRoleInProject: PropTypes.string | ||
| loginUserRoleInProject: PropTypes.string, | ||
| resetFilter: PropTypes.func |
There was a problem hiding this comment.
The resetFilter prop type should be more specific. Consider defining the expected shape or type for this function using PropTypes.func.isRequired if it is mandatory, or PropTypes.func if it is optional.
1 participant
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-2353