Skip to content

Fixing "getRevisionOnlyOnce" flag behavior #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing "getRevisionOnlyOnce" flag behavior #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
829532c
fix problem that revision was calculated for each reactor module even…
pavlukhin Jul 6, 2015
8954124
while -> foreach
pavlukhin Jul 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/main/java/org/codehaus/mojo/build/CreateMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,14 +515,13 @@ else if ( s.startsWith( "buildNumber" ) )
// Add the revision and timestamp properties to each project in the reactor
if ( getRevisionOnlyOnce && reactorProjects != null )
{
Iterator projIter = reactorProjects.iterator();
while ( projIter.hasNext() )
for ( Object nextProjObj : reactorProjects )
{
MavenProject nextProj = (MavenProject) projIter.next();
MavenProject nextProj = (MavenProject) nextProjObj;
if ( revision != null )
{
project.getProperties().put( buildIdPropertyName, revision );
project.getProperties().put( buildNumberPropertyName, formatBuildNumber(commitNumber) );
nextProj.getProperties().put( buildIdPropertyName, revision );
nextProj.getProperties().put( buildNumberPropertyName, formatBuildNumber(commitNumber) );
}
nextProj.getProperties().put( this.timestampPropertyName, timestamp );
nextProj.getProperties().put( this.scmBranchPropertyName, scmBranch );
Expand Down Expand Up @@ -1056,4 +1055,4 @@ public List<String> getLines() {
}


}
}