-
Notifications
You must be signed in to change notification settings - Fork 44
fix(clip-folder): クリップフォルダ内のメッセージの時系列を修正する #4828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview (prod) → https://4828-prod.traq-preview.trapti.tech/ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4828 +/- ##
=======================================
Coverage 13.53% 13.53%
=======================================
Files 704 704
Lines 31729 31729
Branches 677 677
=======================================
Hits 4294 4294
Misses 27423 27423
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asc を名前から外す理由は?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desc には何もついていないのに asc だけ明示しているのに若干違和感があった (おそらく元々の実装で reverse を非破壊と勘違いしていて、代入し直すための変数として message と衝突しない messageAsc が選ばれた?) のと、すぐ近くで order: 'asc' を明示しているのでわざわざ明示する意味が薄いと感じたからです
asc が付いている方が良さそうなら戻します
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desc と asc は区別した方が後々分かりやすいような気がするな (useChannelMessageFetcher はそれなりに複雑な実装だと思うし) 両方付ける用に統一して toReversed() で非破壊に操作すると良いかも
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
たしかにです、そうします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4b54c82 to
78641a6
Compare
78641a6 to
0cbcea1
Compare

なぜこの PR を入れたいのか
closes: #4427
PR を出す前の確認事項