feat: 選択中のクリップフォルダーを強調表示する #4865
Open
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4865-prod.traq-preview.trapti.tech/ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4865 +/- ##
==========================================
- Coverage 13.55% 13.55% -0.01%
==========================================
Files 704 704
Lines 31646 31658 +12
Branches 676 676
==========================================
Hits 4290 4290
- Misses 27344 27356 +12
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| name="bookmark" | ||
| mdi | ||
| :class="$style.icon" | ||
| :data-is-selected="$boolAttr(isSelected)" |
There was a problem hiding this comment.
data-is-selected の代わりに aria-selected を使って，aria-role='tab' と aria-controls を指定するといいかも
There was a problem hiding this comment.
aria-controls まで指定しようとすると少々面倒 (PR のスコープ外の差分が大きくなってしまう) かもだから無視でもいいもしれない
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜこの PR を入れたいのか
close: #3129
UI 変更部分のスクリーンショット
before
after
PR を出す前の確認事項