Skip to content

Conversation

@uni-kakurenbo
Copy link
Contributor

@uni-kakurenbo uni-kakurenbo commented Oct 5, 2025

概要

Notification prompting can only be done from a user gesture.

と怒られてしまうので,Toast のクリックを経由するようにする

なぜこの PR を入れたいのか

closes: #4609

動作確認の手順

  • Playwrgiht を用いて検証した (Playwright の制約上 denide になってしまうが,当該エラーが解消されていることは確認できた.)
  • iPad (iOS 26) 実機を用いて期待通りの動作になっているか確かめた

UI 変更部分のスクリーンショット

image

PR を出す前の確認事項

  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

@uni-kakurenbo uni-kakurenbo requested a review from Copilot October 5, 2025 15:30
@github-actions
Copy link

github-actions bot commented Oct 5, 2025

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 4.44444% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.57%. Comparing base (f60357d) to head (14d783d).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/notification/notification.ts 8.00% 23 Missing ⚠️
src/components/Toast/AToast.vue 0.00% 12 Missing ⚠️
src/store/ui/toast.ts 0.00% 6 Missing ⚠️
...mponents/Settings/BrowserTab/NotificationState.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4875      +/-   ##
==========================================
+ Coverage   13.55%   13.57%   +0.01%     
==========================================
  Files         704      703       -1     
  Lines       31664    31691      +27     
  Branches      676      676              
==========================================
+ Hits         4293     4301       +8     
- Misses      27359    27378      +19     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo force-pushed the fix/webkit-notification-popup branch 2 times, most recently from 4266e2f to 27183c7 Compare October 5, 2025 15:51
@uni-kakurenbo uni-kakurenbo self-assigned this Oct 5, 2025
@uni-kakurenbo uni-kakurenbo marked this pull request as draft October 5, 2025 15:54
@uni-kakurenbo uni-kakurenbo added the bug Something isn't working label Oct 5, 2025
@uni-kakurenbo uni-kakurenbo moved this from Inbox to In progress in traQ Client Oct 5, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the fix/webkit-notification-popup branch 4 times, most recently from 27183c7 to 9d1bc66 Compare October 6, 2025 12:21
@uni-kakurenbo uni-kakurenbo force-pushed the fix/webkit-notification-popup branch from 9d1bc66 to 14d783d Compare October 6, 2025 13:15
@uni-kakurenbo uni-kakurenbo changed the title fix: WebKit 系ブラウザにおいて通知の許可を求める popup が出ない問題の代替案 fix(nortification): WebKit 系ブラウザにおいて通知の許可を求める popup が出ない問題の代替案 Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

iOSユーザーがtraQを始めて開いたときに通知を求めるポップアップが出ない

2 participants