-
Notifications
You must be signed in to change notification settings - Fork 45
OpenAI agents docs #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: 1sebastian1sosa1 <[email protected]>
WalkthroughThe documentation was updated to generalize references to supported LLM frameworks by replacing explicit framework names with links to a centralized list of supported frameworks. Additionally, "OpenAI Agents" was added as a supported framework in the relevant documentation section. No changes were made to code, logic, or public entities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 1191cb0 in 1 minute and 20 seconds. Click for details.
- Reviewed
87
lines of code in7
files - Skipped
0
files when reviewing. - Skipped posting
8
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. monitoring/introduction.mdx:9
- Draft comment:
Updated link to [supported LLM framework] improves clarity and maintainability. Confirm that '/openllmetry/tracing/supported#frameworks' is the intended anchor. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. openllmetry/getting-started-nextjs.mdx:175
- Draft comment:
Consistent update: replacing explicit framework names with a link to [supported LLM framework] improves doc upkeep. Verify that the supported frameworks list is up‐to‐date. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify that the supported frameworks list is up-to-date, which falls under the rule of not asking the author to ensure or verify things. It doesn't provide a specific code suggestion or ask for a specific test to be written. Therefore, it should be removed.
3. openllmetry/getting-started-python.mdx:60
- Draft comment:
Tip update: Using the [supported LLM framework] link streamlines guidance and aligns with other SDK docs. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states a tip about using a supported LLM framework link, which does not align with the rules for useful comments.
4. openllmetry/getting-started-ts.mdx:73
- Draft comment:
Updated tip in the Typescript guide now references [supported LLM framework], ensuring consistency across documentation. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, as it only states that a tip in the Typescript guide has been updated to reference a supported LLM framework. It does not provide any actionable feedback or suggestions for improvement.
5. openllmetry/introduction.mdx:12
- Draft comment:
Link update in the tip now directs to [supported LLM framework], which improves clarity about framework support vs. direct API usage. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, as it only describes what the change does without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest improvements.
6. openllmetry/tracing/annotations.mdx:14
- Draft comment:
Updated tip in annotations docs now links to [supported LLM framework] for clarity and consistency in usage instructions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, as it only states that a tip in the documentation has been updated to link to a supported framework. It doesn't provide any actionable feedback or suggestions for improvement.
7. openllmetry/tracing/supported.mdx:53
- Draft comment:
Added 'OpenAI Agents' to the supported frameworks table. Please verify that the support status (Python: ✅, Typescript: ❌) is accurate. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify the accuracy of the support status for 'OpenAI Agents' in the supported frameworks table. This falls under asking the author to confirm or double-check something, which is against the rules.
8. openllmetry/introduction.mdx:15
- Draft comment:
Typo: The term "OpenLLMetry" appears here. It looks like it might be a misspelling of "OpenTelemetry" (as mentioned earlier in the document). Please verify and correct if necessary. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_z2TD9y0jWsypBlX3
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
openllmetry/getting-started-ts.mdx (1)
75-78
: Double-check anchor validity & tighten copy
- Ensure
/openllmetry/tracing/supported#frameworks
is the correct anchor. If the section header ever changes, the link will silently break.- Minor wording polish: use an em-dash instead of a trailing dash+line-break and drop the extra space.
-If you're using a [supported LLM framework](/openllmetry/tracing/supported#frameworks) - - we'll do that for you. No need to add any annotations to your code. +If you're using a [supported LLM framework](/openllmetry/tracing/supported#frameworks), +we’ll do that for you—no need to add any annotations to your code.openllmetry/getting-started-python.mdx (1)
60-63
: Keep link in sync & streamline phrasingSame comments as the TS doc: verify the
#frameworks
anchor and switch to a comma + em-dash for smoother reading.-If you're using a [supported LLM framework](/openllmetry/tracing/supported#frameworks) - - we'll do that for you. No need to add any annotations to your code. +If you're using a [supported LLM framework](/openllmetry/tracing/supported#frameworks), +we’ll do that for you—no need to add any annotations to your code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
monitoring/introduction.mdx
(1 hunks)openllmetry/getting-started-nextjs.mdx
(1 hunks)openllmetry/getting-started-python.mdx
(1 hunks)openllmetry/getting-started-ts.mdx
(1 hunks)openllmetry/introduction.mdx
(1 hunks)openllmetry/tracing/annotations.mdx
(1 hunks)openllmetry/tracing/supported.mdx
(1 hunks)
🔇 Additional comments (4)
openllmetry/tracing/supported.mdx (1)
53-54
: Entry addition looks accurateThe new “OpenAI Agents” row is alphabetically positioned and the support flags match the current SDK reality. No further changes needed.
openllmetry/introduction.mdx (1)
14-16
: Anchor checkThe new link to
/openllmetry/tracing/supported#frameworks
should resolve to the “Frameworks” section slug. It usually does, but please do a quick local run to confirm the hash is indeed#frameworks
(Docusaurus sometimes lower-cases headers or adds dashes for duplicates).openllmetry/getting-started-nextjs.mdx (1)
178-180
: Consistent phrasing 👍The generic reference keeps the docs DRY and future-proof.
openllmetry/tracing/annotations.mdx (1)
14-16
: Good cross-linkingSame comment as above: just double-check the
#frameworks
hash renders exactly as written to avoid a silent 404.
This is correct Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
OpenAI agent docs & backlinks when mentioning llm agent frameworks (to avoid bloated docs)
Important
Update documentation to include OpenAI Agents as a supported framework and link to supported frameworks list.
supported.mdx
.[supported LLM framework](/openllmetry/tracing/supported#frameworks)
inintroduction.mdx
,getting-started-nextjs.mdx
,getting-started-python.mdx
,getting-started-ts.mdx
, andannotations.mdx
.This description was created by
for 1191cb0. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit