Remove deprecated v8::Object::CreationContext() #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was deprecated for a while, and is completely removed in Electron 20, causing compile errors. GetCreationContextChecked() seems to be a drop-in replacement. See https://groups.google.com/a/chromium.org/g/blink-reviews-bindings/c/VxbRacYaigA for precedent.
JakeChampion
added a commit
to fastly/js-compute-runtime
that referenced
this pull request
Dec 10, 2022
…9 yet The dependency tree-sitter does not yet compile for node 19 due to using a function which has been removed from v8 -- tree-sitter has a patch to get working on node 19 but it isn’t ready yet — tree-sitter/node-tree-sitter#113 in the interim, let's mark node 19 as not supported
Collaborator
|
This was done in #134 in a backwards-compatible way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was deprecated for a while, and is completely removed in Electron 20, causing compile errors. GetCreationContextChecked() seems to be a drop-in replacement. See https://groups.google.com/a/chromium.org/g/blink-reviews-bindings/c/VxbRacYaigA for precedent.