Enforce non-empty metadata keys in forms #9650
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
force-pushed
the
fix/empty-metadata-keys-are-allowed-5251
branch
2 times, most recently
from
8047280 to
5acff90
Compare
zubron
added
area/UI
zubron
changed the title
zubron
force-pushed
the
fix/empty-metadata-keys-are-allowed-5251
branch
4 times, most recently
from
33df7ec to
19508be
Compare
zubron
changed the title
Add client-side validation to prevent form submission (commit, merge, import) when metadata keys are empty or whitespace-only. Fields are marked invalid when: - User blurs an empty key input - Form is submitted with empty keys Invalid fields display "Key is required" error message. Added component tests using React Testing Library to verify validation behavior. Closes #5251
zubron
force-pushed
the
fix/empty-metadata-keys-are-allowed-5251
branch
from
19508be to
47c9992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5251
Change Description
Background
The UI for adding metadata fields allowed empty key-value pairs to be added. This is different from the CLI behaviour which filters them. While we plan to add server-side validation to forbid empty metadata keys in a future update, for now, we want to provide client-side validation to give immediate user feedback and avoid unnecessary API calls that would fail validation.
Bug Fix
Add client-side validation to prevent form submission (commit, merge, import) when metadata keys are empty or whitespace-only.
Fields are marked as invalid when:
Invalid fields display "Key is required" error message.
Testing Details
Added component tests using React Testing Library to verify validation behaviour.
Also performed manual testing to verify behaviour when interacting with many fields.